<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally
#### Description Nightly builds broke due to https://github.com/kamailio/kamailio/commit/c8d56ed3afa19c29279e54fffd40b981... https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/2517/console
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3623
-- Commit Summary --
* secsipid: fix build errors for older verions of secsipid lib
-- File Changes --
M src/modules/secsipid/secsipid_mod.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3623.patch https://github.com/kamailio/kamailio/pull/3623.diff
@linuxmaniac pushed 1 commit.
256f9809644fb70c8d7be6b2d04cdbf18e5e006d secsipid: fix build errors for older versions of secsipid lib
I have no clue how to get the defined version of the golang lib. I give up
Closed #3623.
Didn't `#if SECSIPID_VERSION >= 0x1030000` work? It should be the way to check the version.
I got confused due to ``src/modules/secsipid_proc/secsipid.h`` having the definition. Yes is should work.
Merged #3623 into master.
Merged #3623 into master.
I removed those .h files, were propagate over the time when there was no libsecsipid install. They are no longer needed.