#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally
#### Description The main goal of the module is to offload the intermediate header processing into the XAVP dynamic container as well as provide with high level methods and pseudovariables to simplify SIP message header modifications.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2156
-- Commit Summary --
* pv_headers: Initial commit
-- File Changes --
A src/modules/pv_headers/Makefile (12) A src/modules/pv_headers/README (332) A src/modules/pv_headers/doc/Makefile (4) A src/modules/pv_headers/doc/functions.xml (131) A src/modules/pv_headers/doc/params.xml (186) A src/modules/pv_headers/doc/pv_headers.xml (39) A src/modules/pv_headers/doc/pv_headers_admin.xml (116) A src/modules/pv_headers/pv_headers.c (351) A src/modules/pv_headers/pv_headers.h (51) A src/modules/pv_headers/pvh_func.c (388) A src/modules/pv_headers/pvh_func.h (38) A src/modules/pv_headers/pvh_hash.c (132) A src/modules/pv_headers/pvh_hash.h (39) A src/modules/pv_headers/pvh_hdr.c (235) A src/modules/pv_headers/pvh_hdr.h (39) A src/modules/pv_headers/pvh_str.c (144) A src/modules/pv_headers/pvh_str.h (38) A src/modules/pv_headers/pvh_xavp.c (1050) A src/modules/pv_headers/pvh_xavp.h (64)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2156.patch https://github.com/kamailio/kamailio/pull/2156.diff
@linuxmaniac pushed 1 commit.
1b6f3bdb74bfc1adbf83f609fe445c8acaa93eb0 Makefile.groups: add new pv_headers to basic group
Interesting module addition, thank you for that. I just had a quick look today, as it is quite some code to read. :-) I noticed two things:
- some missing documentation (3.2 - 3.4) in the README, probably still to be added - it makes probably sense to move the new str and del str functions to core/str.[h,c] and the str copy function to core/ut.h - what do you think?
I looked quickly and I could not spot anything obvious, apart of what @henningw reported regarding the missing parts in the docs -- there are some `??????`. Being a new module, at this moment I don't plan to review more, so I am fine to be merged whenever everyone is ok with it.
* about the missing documentation, It was in the xml I forgot to refresh the README file :-/ * about the str functions... I will create another PR to move them there.
Merged #2156 into master.
-
Daniel-Constantin Mierla -
Henning Westerholt
-
Victor Seva