#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description Added SCTP support for CDP module You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3327
-- Commit Summary --
* cdp: Add SCTP support
-- File Changes --
M src/modules/cdp/acceptor.c (2) M src/modules/cdp/config.h (4) M src/modules/cdp/configexample/ConfigExample.xml (5) M src/modules/cdp/configparser.c (10) M src/modules/cdp/peer.c (3) M src/modules/cdp/peer.h (3) M src/modules/cdp/peermanager.c (4) M src/modules/cdp/receiver.c (7) M src/modules/cdp/tcp_accept.c (9) M src/modules/cdp/tcp_accept.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3327.patch https://github.com/kamailio/kamailio/pull/3327.diff
Thanks for the PR, looks good to me. Lets see if there are other comments, otherwise it will be merged soon.
Fine to merge.
Not much acting myself in IMS modules space, but maybe for more flexibility, as a follow up commit, the comparison with `SCTP` can be done case insensitive, to allow both `sctp` or `SCTP` in the xml config. This because I noticed something similar for a node name:
- https://github.com/kamailio/kamailio/pull/3327/commits/72801e2bc6fddd56c4ab0...
@networkmaniac pushed 1 commit.
4a2d8320f1add16ba157d61444e8dc0240d6300e cdp: make ip_proto parameter case insensitive
Thanks for you opinion. Changed to case insensitive.
Merged #3327 into master.
thanks, merged