<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2657
-- Commit Summary --
* Merge pull request #1 from kamailio/master * Merge pull request #2 from kamailio/master * lrkproxy: lreproxy name is changed
-- File Changes --
A src/modules/lrkproxy/Makefile (17) A src/modules/lrkproxy/README (341) A src/modules/lrkproxy/lrkproxy.c (1738) A src/modules/lrkproxy/lrkproxy.h (107) A src/modules/lrkproxy/lrkproxy_funcs.c (479) A src/modules/lrkproxy/lrkproxy_funcs.h (41) A src/modules/lrkproxy/lrkproxy_hash.c (522) A src/modules/lrkproxy/lrkproxy_hash.h (75)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2657.patch https://github.com/kamailio/kamailio/pull/2657.diff
@mojtabaesfandiari: thanks for renaming the module. You still have to add the `doc/` folder in the module with the xml docbook files that can be used to generate the README. Can you add them in this PR?
At the end, probably I will merge the PR manually to set a proper description in the commit message, to correspond to a new module addition, rather than indicating a rename of a former pull request.
@miconda Sure, I will add doc/ folder,too. I might take a little time. I will do it as soon. Thanks
@mojtabaesfandiari I was watching your presentation as Fosdem, you mention that LREproxy can provide NAT traversal for endpoint ?
@jchavanton Absolutely yes, Like as other B2BUA services that supports.
The LRKProxy engine is updated and renamed, too. https://github.com/mojtabaesfandiari/pylrkproxy
@mojtabaesfandiari interesting, I did not see any symmetric latching, HNT hosted NAT traversal logic in the code, can you point out more precisely where this is in the code ?
For the sake of clarity, B2BUA is related to signaling just like user-agent is a SIP concept, in this specific use case it can not be a B2BUA since Kamailio is a proxy. I get that you probably meant anything relaying media can replace an SBC/B2BUA.
@mojtabaesfandiari pushed 1 commit.
279010564fcd3f8d6c8e44ca6e9b0faeac57cccb lrkproxy: add doc/ xml folder
@jchavanton I underestand what you mean. You could have a look in kernel space section code in pylrkproxy engine in https://github.com/mojtabaesfandiari/pylrkproxy/tree/master/lib/c/kernel_spa.... In Kernel space code, we use destination ports of packets as a index to find next endpoint in session.
@mojtabaesfandiari - thanks for the xml docs and the efforts to adjust it to be integrated in Kamailio. I will prepare the PR for a manual merge to look like a fresh import of a new module, then you can get commit access to push future commits to it. You can still use pull requests if you prefer this kind of work flow.
@miconda Great, Thanks :)
Merged with commit:
* https://github.com/kamailio/kamailio/commit/08738ba5a0ee03afa4e47f7174e25a1c...
Further discussions can be done via mailing lists or via new issues on the tracker.
Closed #2657.
@mojtabaesfandiari - sent you invitation to get write access to the github repo to maintain the module. While compiling the module with clang, I found a warning that has to be addressed, reported at:
* https://github.com/kamailio/kamailio/issues/2663
-
Daniel-Constantin Mierla -
Julien Chavanton
-
mojtabaesfandiari