A newly introduced condition in an if () statement leads to core dump in some scenarios. It is removed.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Without this Change a core dump happens in the P-CSCF during handling the SIP REGISTER. Obviously a condition was added to an if() Statement, which itself created a null pointer Access. This additional Statement was removed.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1409
-- Commit Summary --
* pua: removed null pointer access from subscribe_cbparam()
-- File Changes --
M src/modules/pua/send_subscribe.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1409.patch https://github.com/kamailio/kamailio/pull/1409.diff
Thanks for finding this, looks like a copy&paste issue, so I think the condition should not be removed but fixed -- instead of:
``` if(subs->extra_headers && hentity->extra_headers->s) ```
There should be:
``` if(subs->extra_headers && subst->extra_headers->s) ```
Hi,
Can you do it the way you proposed? I’d have to create a new branch for this anyway.
KR
From: Daniel-Constantin Mierla [mailto:notifications@github.com] Sent: Thursday, January 25, 2018 2:46 PM To: kamailio/kamailio kamailio@noreply.github.com Cc: Valentin Christoph Christoph.Valentin@kapsch.net; Author author@noreply.github.com Subject: Re: [kamailio/kamailio] pua: removed null pointer access from subscribe_cbparam() (#1409)
Thanks for finding this, looks like a copy&paste issue, so I think the condition should not be removed but fixed -- instead of:
if(subs->extra_headers && hentity->extra_headers->s)
There should be:
if(subs->extra_headers && subst->extra_headers->s)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/kamailio/kamailio/pull/1409#issuecomment-360470585, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AcOqyInFopeBjB3PammlkF94ZwU4azDRks5tOIWfgaJpZM4Rs1nY.
The information contained in this e-mail message is privileged and confidential and is for the exclusive use of the addressee. The person who receives this message and who is not the addressee, one of his employees or an agent entitled to hand it over to the addressee, is informed that he may not use, disclose or reproduce the contents thereof, and is kindly asked to notify the sender and delete the e-mail immediately.
Done in master, I will backport soon.
Closed #1409.
Will you backport to 5.1 ? Should I create a 5.1 pull request?