<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2846
-- Commit Summary --
* snmpstats: add parameter to specify SNMP version
-- File Changes --
M src/modules/snmpstats/doc/snmpstats_admin.xml (26) M src/modules/snmpstats/snmpstats.c (30) M src/modules/snmpstats/snmpstats_globals.h (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2846.patch https://github.com/kamailio/kamailio/pull/2846.diff
### Background I saw an error in the logs ``` ERROR: snmpstats [snmpSIPCommonObjects.c:200]: handle_kamailioSIPServiceStartTime(): failed to read from sysUpTime file at /tmp/kamailio_SNMPAgent.txt ``` and began to figure out what kind of file it is. The file is filled with the command output ``` # snmpget -Ov -c public localhost .1.3.6.1.2.1.1.3.0 ```
### Actual behavior Manual command execution failed ``` # snmpget -Ov -c public localhost .1.3.6.1.2.1.1.3.0 snmpget: No securityName specified ```
### Expected behavior Command returns uptime (in this case I specified SNMP version) ``` # snmpget -v2c -Ov -c public localhost .1.3.6.1.2.1.1.3.0 Timeticks: (60857281) 7 days, 1:02:52.81 ```
Thank you for the pull request, looks good to me. Its a small extension and you adapted it good to the existing module code structure, merged.
Merged #2846 into master.