2 Dec
2016
2 Dec
'16
3:55 p.m.
- modified pv_parse_hep_name() and pv_get_hep() to expose
the HEP's packet source ip address on replies. The associated
pv $hep(src_ip), i.e.:
onreply_route {
...
xlog("[onreply_route] Source IP: $hep(src_ip)\n");
...
}
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/879
-- Commit Summary --
* sipcapture: expose pv $hep(src_ip)
-- File Changes --
M modules/sipcapture/sipcapture.c (15)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/879.patch
https://github.com/kamailio/kamailio/pull/879.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879
2 Dec
2 Dec
3:57 p.m.
@adubovikov I hope this is better. If you find I'm not adhering in any way to
guidelines, please point them out as it's my first time contributing.
Many thanks!
David
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879#issuecomment-264459253
4 Dec
4 Dec
11:03 a.m.
miconda commented on this pull request.
the declaraton of buf_ip has to be static because you return the pointer to it. Right now
it is allocated on the stack and the pointer becomes invalid when the function finishes
its execution. It has to be like:
```
static char buf_ip ...
```
Alternative is to use the core buffer for pvs, that you can retrieve with pv_get_buffer()
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879#pullrequestreview-11291197
6 Dec
6 Dec
10:19 a.m.
@davidcsi pushed 1 commit.
fb6328e sipcapture: Set char buf_ip as static
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/879/files/b8680815fc46c6612de9d41…
10:21 a.m.
Changed "char buf_ip" as static
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879#issuecomment-265088845
7 Dec
7 Dec
10:12 a.m.
@adubovikov - is this pull ok to merge? If yes, then let me do it manually this time,
because I am going to work on restructuring of the source code tree and don't want to
mess it.
@davidcsi - for the future pull requests, do not do reformatting (indentation changes,
renaming, etc.) in a pull request with new features, because it is hard to review the
additions to the code. We value a lot the pull requests for beautification, they are very
welcome, but do them as separate patches. In this specific case, your addition seems not
to have coherent indentation, but you tried to do for other parts of existing code.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879#issuecomment-265383287
10:15 a.m.
I am ok for this. Of course ideally will be add more "aliases" but it's ok
for start! :-)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879#issuecomment-265383852
8 Dec
8 Dec
10:23 p.m.
Yes, sorry about those beautifications... vim (spf13 mod) did it automatically.. i'll
be more careful in the future.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879#issuecomment-265845215
9 Dec
9 Dec
11:18 a.m.
I reworked the patch to use buffered print of ip address in order to avoid the str copy.
Test and if any issue is found, open a bug report.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879#issuecomment-265968665
11:18 a.m.
Closed #879.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879#event-888072343
2936
days inactive
2943
days old
9 comments
3 participants
participants (3)
-
Alexandr Dubovikov -
Daniel-Constantin Mierla
-
David Villasmil