As proposed on the mailing list (http://lists.sip-router.org/pipermail/sr-dev/2014-December/026514.html), here is a patch to be able to retrieve the new SDP in an avp You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/64
-- Commit Summary --
* modules/rtpengine: return the new SDP in an AVP * rtpengine: README update
-- File Changes --
M modules/rtpengine/README (70) M modules/rtpengine/doc/rtpengine_admin.xml (20) M modules/rtpengine/rtpengine.c (59)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/64.patch https://github.com/kamailio/kamailio/pull/64.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/64
On Monday 02 February 2015 17:20:29 Camille Oudot wrote:
As proposed on the mailing list (http://lists.sip-router.org/pipermail/sr-dev/2014-December/026514.html), here is a patch to be able to retrieve the new
SDP in an avp
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/64
-- Commit Summary --
- modules/rtpengine: return the new SDP in an AVP
- rtpengine: README update
The patch is mixing shm_malloc and pkg_free.
Why is it limited to AVP's?
Maybe i misread, but it seems there is only one value written in the variable and it doesn't need to be stored in the transaction. So there seems to be no use for storing in an AVP and i think it could be extended to allow any writable PV.
Thanks for the review, there is a shm/pkg mixup indeed. Seems like avp_add() aready takes care of shm_malloc() anyway.
There is no also absolute need to restrict to AVP, i will add support for script $var() also.
Closing this pull request. I will post a new clean patch.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/64#issuecomment-73503365
Closed #64.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/64#event-232430845
-
Alex Hermann -
Camille Oudot