- deletes expired presentity records without sending a NOTIFY - `force_delete` disabled by default You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/601
-- Commit Summary --
* presence: introduce new module parameter `force_delete`
-- File Changes --
M modules/presence/presence.c (5) M modules/presence/presence.h (1) M modules/presence/publish.c (74)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/601.patch https://github.com/kamailio/kamailio/pull/601.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/601
@miconda here is PR for new presence parameter
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/601#issuecomment-217447374
Good timing. Literally just came out of a meeting where the undesirable behavior of repeated `terminated` NOTIFY messages was discussed. This is a useful addition.
You've changed a lot of whitespace that is not related to this PR. Makes it very difficult to digest :/
Appreciate this isn't your doing and you've just copied the `LM_ERR` from the rest of the code, but these log levels look a little enthusiastic. These are debug logs - perhaps info at best.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/601#issuecomment-217452341
@phil-lavin sorry about the whitespace changes, I learned from my mistake and will fix whitespace in a separate commit from now on. The only significant change to the code is here: ```if (delete_presentity(&pres) < 0) { LM_ERR("Deleting presentity\n"); goto error; }```
And if you look at full code, you'll see I just copied it from a few lines below it. You are welcome to change the log levels in a separate PR! Thanks, Emmanuel
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/601#issuecomment-217453485
Thanks, it will be merged!
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/601#issuecomment-217612878
Merged #601.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/601#event-653368969
-
Daniel-Constantin Mierla -
Emmanuel Schmidbauer
-
Phil Lavin