giupand created an issue (kamailio/kamailio#4330)
<!-- Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio....
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.or...
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months if there is no interest from developers or community users on pursuing it, being considered expired. In such case, it can be reopened by writing a comment that includes the token `/notexpired`. About two weeks before considered expired, the issue is marked with the label `stale`, trying to notify the submitter and everyone else that might be interested in it. To remove the label `stale`, write a comment that includes the token `/notstale`. Also, any comment postpone the `expire` timeline, being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment). -->
### Description
<!-- Explain what you did, what you expected to happen, and what actually happened. --> Hi, I have a question about the dispatcher OPTIONS keepalive in Kamailio version 5.6.1.
I have a dispatcher configuration that probes two destinations with the same destination URI but using different sockets (see the database below), and the OPTIONS keepalive is enabled (status AP). When the first destination (ID 27) goes down, its status changes to IP, and the second destination remains in AP. However, when the second destination (ID 28) goes down, its status remains in AP, and the event_route[dispatcher:dst-down] does not seem to trigger.
``` +----+-------+------------------------+-------+----------+----------------------------------------------------------------------------------------------------------------+----------------+ | id | setid | destination | flags | priority | attrs | description | +----+-------+------------------------+-------+----------+----------------------------------------------------------------------------------------------------------------+----------------+ | 27 | 29 | sip:192.168.2.222:5060 | 2 | 21 | ping_from=sip:27@domain.com;socket=udp:192.168.2.250:5060 | | | 28 | 29 | sip:192.168.2.222:5060 | 2 | 12 | ping_from=sip:28@domain.com;socket=udp:192.168.2.246:5060 | | +----+-------+------------------------+-------+----------+----------------------------------------------------------------------------------------------------------------+----------------+ ```
Wathcing the dispatcher code in Kamailio 5.6.1, I noticed that in the ds_update_state function, there is a loop over the dlist that performs a match on the destination using the input address parameter.
``` int ds_update_state(sip_msg_t *msg, int group, str *address, int state,ds_rctx_t *rctx) [...] while(i < idx->nr) { if(idx->dlist[i].uri.len == address->len && strncasecmp(idx->dlist[i].uri.s, address->s, address->len) == 0) { [...] ```
With the current database configuration, I believe the match is found only for the first entry (ID 27), and not for the second entry (ID 28). **As a result, the status update doesn't seem to work for the second destination.**
Is this a bug, or is there something wrong with my configuration? ### Troubleshooting
#### Reproduction
<!-- If the issue can be reproduced, describe how it can be done. -->
#### Debugging Data
<!-- If you got a core dump, use gdb to extract troubleshooting data - full backtrace, local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile bt full info locals list
If you are familiar with gdb, feel free to attach more of what you consider to be relevant. -->
``` (paste your debugging data here) ```
#### Log Messages
<!-- Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site). -->
``` (paste your log messages here) ```
#### SIP Traffic
<!-- If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site). -->
``` (paste your sip traffic here) ```
### Possible Solutions
<!-- If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix. -->
### Additional Information
* **Kamailio Version** - output of `kamailio -v` version: kamailio 5.6.1 (x86_64/linux) flags: USE_TCP, USE_TLS, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
``` (paste your output here) ```
* **Operating System**:
<!-- Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...; Kernel details (output of `lsb_release -a` and `uname -a`) -->
``` (paste your output here) ```
suiyuemanbu left a comment (kamailio/kamailio#4330)
while(i < idx->nr) { if(idx->dlist[i].uri.len == address->len && strncasecmp(idx->dlist[i].uri.s, address->s, address->len) == 0) { /* destination address found */ old_state = idx->dlist[i].flags;
[...]
return 0; //Removing this return will meet your needs. !!! } i++; }
giupand left a comment (kamailio/kamailio#4330)
It doesn't work well... The goal is: when the destination 192.168.2.222 is not reachable from its socket goes down. DEST 1: URI: sip:192.168.2.222:5060 its SOCKET: udp:192.168.2.250:5060 DEST 2: URI: sip:192.168.2.222:5060 its SOCKET: udp:192.168.2.246:5060
when DEST 1 isnt reachable from udp:192.168.2.250:5060, it goes down and state will be IP if DEST 2 is reachable from udp:192.168.2.246:5060, it stay in AP state
when also DEST 2 isnt reachable from udp:192.168.2.246:5060, it goes down and state will be IP
With your modify (//return 0), when the frist destination goes down both destinations goes in IP state (see dispatcher.list output) instead should be only first destination in IP state because the second destination is still reachable from udp:192.168.2.246:5060 socket.
``` SET: { ID: 29 TARGETS: { DEST: { URI: sip:192.168.2.222:5060 FLAGS: IP PRIORITY: 21 ATTRS: { BODY: ping_from=sip:27@domain.com;socket=udp:192.168.2.250:5060 DUID: <null string> MAXLOAD: 0 WEIGHT: 0 RWEIGHT: 0 SOCKET: udp:192.168.2.250:5060 SOCKNAME: <null string> OBPROXY: <null string> } RUNTIME: { DLGLOAD: 0 } } DEST: { URI: sip:192.168.2.222:5060 FLAGS: IP PRIORITY: 12 ATTRS: { BODY: ping_from=sip:28@domain.com;socket=udp:192.168.2.246:5060 DUID: <null string> MAXLOAD: 0 WEIGHT: 0 RWEIGHT: 0 SOCKET: udp:192.168.2.246:5060 SOCKNAME: <null string> OBPROXY: <null string> } RUNTIME: { DLGLOAD: 0 } } } }
```
giupand left a comment (kamailio/kamailio#4330)
do you have any news? thanks
miconda left a comment (kamailio/kamailio#4330)
The dispatcher was designed on matching the group and destination address, not the attributes (which were added later). If one needs other matching criteria, then C development has to be done. Contributions can be made with pull requests.