fix wrong function invocation period for secondary timer. i have noticed new secondary timer invocation period error , while looking at commit 93b5d2e functions called more often than it should due to (c % wt->cycles==0) is TRUE.
i'm not sure this is the best possible fix, but it works
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/487
-- Commit Summary --
* core: secondary timer interval
-- File Changes --
M timer_proc.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/487.patch https://github.com/kamailio/kamailio/pull/487.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/487
Thanks for heads up! I reimplemented the secondary timer as classic wheel timer -- initially I played with the idea of optimizing it for intervals fitting many times in the number of slots, but becomes too complex to deal with exceptions.
Trying the last master branch and reporting the results would be very appreciated.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/487#issuecomment-174731667
Closed #487.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/487#event-525747170
it works fine now for usrloc and dispatcher secondary timers
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/487#issuecomment-174957406
-
Daniel-Constantin Mierla -
Dmitri Savolainen