<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [ ] Tested changes locally
#### Description From https://github.com/kamailio/kamailio/pull/3569
After initial subscription by the SCA device, if we power off and on again, we won't get an unsubscribe notification and we are getting a new record-route with sca-subscription. In this case kamailio not updating the new record-route for the SCA Device.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3571
-- Commit Summary --
* sca: update rr if necessary for subscriptions
-- File Changes --
M src/modules/sca/sca_subscribe.c (11)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3571.patch https://github.com/kamailio/kamailio/pull/3571.diff
@schiramchetty can you please try this one instead?
Should this be merged?
I'm still waiting for @schiramchetty feedback
Hi,
Thanks for the reply, Please give me a week. I will update you ASAP.
On Thu, Oct 5, 2023 at 12:00 PM Victor Seva ***@***.***> wrote:
I'm still waiting for @schiramchetty https://github.com/schiramchetty feedback
— Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/3571#issuecomment-1748169931, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYMELK24PGZGD35Y2GO4BQLX5ZHXNAVCNFSM6AAAAAA4X4IW7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYGE3DSOJTGE . You are receiving this because you were mentioned.Message ID: ***@***.***>
@schiramchetty any news?
Merged #3571 into master.