#### Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description srjson_DeleteDoc(ctx->jreq) is already called in jsonrpc_clean_context(ctx). Calling it twice causes a crash due to a double free attempt. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1839
-- Commit Summary --
* jsonrpcs: fix double free crash
-- File Changes --
M src/modules/jsonrpcs/jsonrpcs_mod.c (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1839.patch https://github.com/kamailio/kamailio/pull/1839.diff
Was this added in a recent commit, right?
Yes, was added in 8e5742ff1657bdb2adce357fc6f1a2e04fd913c6.
On Thu, Feb 7, 2019 at 9:31 AM Daniel-Constantin Mierla < notifications@github.com> wrote:
Was this added in a recent commit, right?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/1839#issuecomment-461328477, or mute the thread https://github.com/notifications/unsubscribe-auth/AF36ZXfuUkin2EZuHaFbkontQNA_v84Hks5vK-RbgaJpZM4amzSK . _______________________________________________ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Was this added in a recent commit, right?
It can be merged and backported if needed. Thanks!
Merged #1839 into master.
Please also backport to `5.0` branch.
@btriller - sorry, 5.0 is end of life and will not receive any updates anymore: https://www.kamailio.org/w/2019/04/kamailio-v5-0-8-released/ Please upgrade to a supported version of Kamailio.
@henningw w/o this patch `5.0` branch is unusable with default config.
Thanks for the reminder. As already mentioned, 5.0 is EOL and will not receive any updates anymore, sorry. I have forwarded you the patch over e-mail.