Module: kamailio Branch: master Commit: b59771bb81bbe240b98113252df10377a75da700 URL: https://github.com/kamailio/kamailio/commit/b59771bb81bbe240b98113252df10377...
Author: Mikko Lehto mslehto@iki.fi Committer: Mikko Lehto mslehto@iki.fi Date: 2017-07-25T15:54:57+03:00
modules/sipcapture: fix (param_export_t).name typo
---
Modified: src/modules/sipcapture/sipcapture.c
---
Diff: https://github.com/kamailio/kamailio/commit/b59771bb81bbe240b98113252df10377... Patch: https://github.com/kamailio/kamailio/commit/b59771bb81bbe240b98113252df10377...
---
diff --git a/src/modules/sipcapture/sipcapture.c b/src/modules/sipcapture/sipcapture.c index beaff682d3..1c365f8168 100644 --- a/src/modules/sipcapture/sipcapture.c +++ b/src/modules/sipcapture/sipcapture.c @@ -367,7 +367,7 @@ static param_export_t params[] = { {"insert_retries", INT_PARAM, &insert_retries }, {"insert_retry_timeout", INT_PARAM, &insert_retry_timeout }, {"table_time_sufix", PARAM_STR, &table_time_sufix }, - {"topoh_unamsk", PARAM_INT, &sc_topoh_unmask }, + {"topoh_unmask", PARAM_INT, &sc_topoh_unmask }, {"nonsip_hook", PARAM_INT, &nonsip_hook }, {0, 0, 0} };
diff --git a/src/modules/sipcapture/sipcapture.c b/src/modules/sipcapture/sipcapture.c index beaff682d3..1c365f8168 100644 --- a/src/modules/sipcapture/sipcapture.c +++ b/src/modules/sipcapture/sipcapture.c @@ -367,7 +367,7 @@ static param_export_t params[] = { {"insert_retries", INT_PARAM, &insert_retries }, {"insert_retry_timeout", INT_PARAM, &insert_retry_timeout }, {"table_time_sufix", PARAM_STR, &table_time_sufix },
- {"topoh_unamsk", PARAM_INT, &sc_topoh_unmask },
- {"topoh_unmask", PARAM_INT, &sc_topoh_unmask }, {"nonsip_hook", PARAM_INT, &nonsip_hook }, {0, 0, 0}
};
This looks innocent, but not being topoh user, I cannot verify if activated code paths are free of troubles in real world.
Same typo exists in 5.0.
If the documentation is without the typo, then it can be backported.
Cheers, Daniel
On 25.07.17 15:06, Mikko Lehto wrote:
diff --git a/src/modules/sipcapture/sipcapture.c b/src/modules/sipcapture/sipcapture.c index beaff682d3..1c365f8168 100644 --- a/src/modules/sipcapture/sipcapture.c +++ b/src/modules/sipcapture/sipcapture.c @@ -367,7 +367,7 @@ static param_export_t params[] = { {"insert_retries", INT_PARAM, &insert_retries }, {"insert_retry_timeout", INT_PARAM, &insert_retry_timeout }, {"table_time_sufix", PARAM_STR, &table_time_sufix },
- {"topoh_unamsk", PARAM_INT, &sc_topoh_unmask },
- {"topoh_unmask", PARAM_INT, &sc_topoh_unmask }, {"nonsip_hook", PARAM_INT, &nonsip_hook }, {0, 0, 0}
};
This looks innocent, but not being topoh user, I cannot verify if activated code paths are free of troubles in real world.
Same typo exists in 5.0.
2017-07-25 (Tue) 18:52 UTC +0200 Daniel-Constantin Mierla miconda@gmail.com:
If the documentation is without the typo, then it can be backported.
Documentation was correct on 5.0 branch. Backported.