#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Not related to issues
#### Description `Makefile.defs` is incorrect (`man_dir` should contain `share`) and `influxdbc` is not built (`sockaddr_in` is undefined) on FreeBSD environment. The proposed patch fixes it and makes the module is consistent with the rest of modules. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4099
-- Commit Summary --
* Makefile.defs: support for FreeBSD build * influxdbc: support for FreeBSD build
-- File Changes --
M src/Makefile.defs (2) M src/modules/influxdbc/ic.c (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4099.patch https://github.com/kamailio/kamailio/pull/4099.diff
Thanks for the PR. Looks like a small and straightforward changed. Lets wait until the beginning of next week for eventual other comments.
It is fine to merge, thanks!
@drTr0jan: would you have time to test the cmake-based building system on FreeBSD? I am not sure if anyone tried it yet, as I can't say if there are many people using FreeBSD active in our development space. The plan is to replace the old-Makefiles with cmake, some tutorials are available at:
- https://www.kamailio.org/wikidocs/tutorials/cmake/
@miconda, I can't promise for the testing, but I'll try. I am a little familiar with CMake. You can open an issue for the testing and assign me.
Maybe it will be useful, for RPM packaging I use ``` %{cmake} \ -DBUILD_DOC=ON \ -DUSE_TLS=ON \ -DINCLUDE_MODULES="pvtpl pua_rpc siprepo systemdops log_systemd db_text acc_json auth_ephemeral jansson db_berkeley"
%{cmake_install} %{cmake_install} --component tls-cfg %{cmake_install} --component xhttp_pi-cfg ```
Merged #4099 into master.
Thanks again, merged
@drTr0jan: would you have time to test the cmake-based building system on FreeBSD? I am not sure if anyone tried it yet, as I can't say if there are many people using FreeBSD active in our development space. The plan is to replace the old-Makefiles with cmake, some tutorials are available at:
@miconda, tested after 6839f1a2e090f06b0b7ca9289dd3b7279903a1e2. Build is OK.
-
Boris Korzun -
Daniel-Constantin Mierla
-
Henning Westerholt
-
sergey-safarov