[kamailio/kamailio] dialog: run DLGCB_LOADED callbacks when loading dialog from db (#2066)
When a specific dialog is loaded from db via dlg_db_load_callid, the load callbacks are not executed so, for example, a CDR is not generated. No sure if this should considered a new feature or a bug (and so eventually be backported). You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2066
-- Commit Summary --
* dialog: run DLGCB_LOADED callbacks when loading dialog from db
-- File Changes --
M src/modules/dialog/dialog.c (1) M src/modules/dialog/dlg_cb.c (17) M src/modules/dialog/dlg_cb.h (1) M src/modules/dialog/dlg_db_handler.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2066.patch https://github.com/kamailio/kamailio/pull/2066.diff
Thanks, it looks good to me. This should fix also the same problem for the dlg_db_load_extra() cfg function. One small thing - would be great if you fix the different code indention in the new function in file dlg_cb.c.
We integrated a similar fix for the uac module some time ago (aa7dee1ab874) also the stable branches. So if no other developers object in the next few days it can be merged and backported in my opinion.
@grumvalski pushed 1 commit.
1d6a06c5cdef9665ec473817235856c22a79949f dialog: fix indentation
Thans for looking Henning, I fixed the indentation (automatic editor settings) and push a new commit. I can rebase/squash before merging. Yes, the fix should also work for dlg_db_load_extra (mode 2 for the function).
@grumvalski pushed 1 commit.
10037f658cd1657275f383314b6960715c17ea39 dialog: run DLGCB_LOADED callbacks when loading dialog from db
From my point of view it is ok to merge and backport if needed.
Thanks. I'm going to merge and backport to 5.2 (where the new functions have been introduced).
Merged #2066 into master.
-
Daniel-Constantin Mierla -
Federico Cabiddu
-
Henning Westerholt