[kamailio/kamailio] modules/sdpops: remove_line_by_prefix pre-check cleanup + new test (#615)
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/615
-- Commit Summary --
* modules/sdpops: remove duplicate body length arithmetic * modules/sdpops: use parse_sdp() return value to bail out on empty body * test/unit: update unit 60
-- File Changes --
M modules/sdpops/sdpops_mod.c (9) A test/unit/60-message-sdp8.sip (9) M test/unit/60.cfg (3) M test/unit/60.sh (17)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/615.patch https://github.com/kamailio/kamailio/pull/615.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/615
Looks like I did not provide any description, sorry about that.
Purpose of these patches is to tidy up unnecessary checks and calculations that are already done by parse_sdp(). Previously created tests (60...) show no change in behaviour and new test confirms that null body does not cause crash.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/615#issuecomment-218976230
Thanks!
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/615#issuecomment-220935273
Merged #615.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/615#event-668718771
-
Daniel-Constantin Mierla -
Mikko Lehto