Module: kamailio Branch: master Commit: 7225ab2c9a3f5524eabdbd729f2fd9c3fafbc56a URL: https://github.com/kamailio/kamailio/commit/7225ab2c9a3f5524eabdbd729f2fd9c3...
Author: Olle E. Johansson oej@edvina.net Committer: Olle E. Johansson oej@edvina.net Date: 2015-02-04T16:38:25+01:00
Merge pull request #68 from linuxmaniac/vseva/corex_doc
Corex: fix documentation of min_msg_len
Code and docs did not agree on the name.
---
Modified: modules/corex/README Modified: modules/corex/doc/corex_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/7225ab2c9a3f5524eabdbd729f2fd9c3... Patch: https://github.com/kamailio/kamailio/commit/7225ab2c9a3f5524eabdbd729f2fd9c3...
I tried merging in the Github web interface. As you see the first line of the commit is not the proper one (following our standards). In the future, I will try to do this manually so that we can have the module name and commit message on the first line.
Sorry for this.
/O
Begin forwarded message:
From: Olle E. Johansson oej@edvina.net Subject: [sr-dev] git:master:7225ab2c: Merge pull request #68 from linuxmaniac/vseva/corex_doc Date: 4 Feb 2015 16:38:31 GMT+1 To: sr-dev@lists.sip-router.org Reply-To: "Kamailio (SER) - Development Mailing List" sr-dev@lists.sip-router.org
Module: kamailio Branch: master Commit: 7225ab2c9a3f5524eabdbd729f2fd9c3fafbc56a URL: https://github.com/kamailio/kamailio/commit/7225ab2c9a3f5524eabdbd729f2fd9c3...
Author: Olle E. Johansson oej@edvina.net Committer: Olle E. Johansson oej@edvina.net Date: 2015-02-04T16:38:25+01:00
Merge pull request #68 from linuxmaniac/vseva/corex_doc
Corex: fix documentation of min_msg_len
Code and docs did not agree on the name.
Modified: modules/corex/README Modified: modules/corex/doc/corex_admin.xml
Diff: https://github.com/kamailio/kamailio/commit/7225ab2c9a3f5524eabdbd729f2fd9c3... Patch: https://github.com/kamailio/kamailio/commit/7225ab2c9a3f5524eabdbd729f2fd9c3...
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
I think we can live with that, otherwise pull requests on github will become not very handy to merge.
What is the important when accepting a pull request is that the commit message itself is formatted -- it appears after the line with 'Merge pull request #...'
I guess approaching the github to ask moving the 'Merge ...' at the end won't be successful, other projects probably likes it, being there for some time.
Cheers, Daniel
On 04/02/15 16:40, Olle E. Johansson wrote:
I tried merging in the Github web interface. As you see the first line of the commit is not the proper one (following our standards). In the future, I will try to do this manually so that we can have the module name and commit message on the first line.
Sorry for this.
/O
Begin forwarded message:
From: Olle E. Johansson oej@edvina.net Subject: [sr-dev] git:master:7225ab2c: Merge pull request #68 from linuxmaniac/vseva/corex_doc Date: 4 Feb 2015 16:38:31 GMT+1 To: sr-dev@lists.sip-router.org Reply-To: "Kamailio (SER) - Development Mailing List" sr-dev@lists.sip-router.org
Module: kamailio Branch: master Commit: 7225ab2c9a3f5524eabdbd729f2fd9c3fafbc56a URL: https://github.com/kamailio/kamailio/commit/7225ab2c9a3f5524eabdbd729f2fd9c3...
Author: Olle E. Johansson oej@edvina.net Committer: Olle E. Johansson oej@edvina.net Date: 2015-02-04T16:38:25+01:00
Merge pull request #68 from linuxmaniac/vseva/corex_doc
Corex: fix documentation of min_msg_len
Code and docs did not agree on the name.
Modified: modules/corex/README Modified: modules/corex/doc/corex_admin.xml
Diff: https://github.com/kamailio/kamailio/commit/7225ab2c9a3f5524eabdbd729f2fd9c3... Patch: https://github.com/kamailio/kamailio/commit/7225ab2c9a3f5524eabdbd729f2fd9c3...
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-
Daniel-Constantin Mierla -
Olle E. Johansson