<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
Added new module param to enable retention of call stats for existing destinations when reloading the list from file or database.
Also updated to retain stats for other destinations when adding/removing individual ones via RPC.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3534
-- Commit Summary --
* dispatcher: add option to retain existing latency stats when reloading destinations
-- File Changes --
M src/modules/dispatcher/dispatch.c (63) M src/modules/dispatcher/dispatch.h (1) M src/modules/dispatcher/dispatcher.c (2) M src/modules/dispatcher/doc/dispatcher_admin.xml (32)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3534.patch https://github.com/kamailio/kamailio/pull/3534.diff
@charlesrchance pushed 1 commit.
6abea9f424b98ffa71471b21de021bba091054dd dispatcher: add option to retain existing latency stats when reloading destinations
@charlesrchance pushed 1 commit.
0b62aff26c8ff93be053338c7916385b6f4f8ecb dispatcher: add option to retain existing latency stats when reloading destinations
@charlesrchance pushed 1 commit.
c91cf41c07a465715db41c6e5038853b53c923af dispatcher: add option to retain existing latency stats when reloading destinations
Nice ! I am not sure this should be optional, I mean most if not all will want to retain the stats.
Thanks!
I agree...happy to make it the default if others think the same, but we never quite know how it's already being used and who relies on a reload to actually reset the stats.
@charlesrchance pushed 1 commit.
852dc0848843b2886da3edfa9d1fd96c04e182aa dispatcher: add option to retain existing latency stats when reloading destinations
@charlesrchance pushed 1 commit.
011dca2e5a07d76b46e86c7fa4ac4fbe3a5851a0 dispatcher: add option to retain existing latency stats when reloading destinations
Fine to merge from my point of view, if no other comments.
I have no strong opinion on the question regarding the default value. Merging it, thank you. If somebody thinks that it should be configured differently w/r to the default value, it can be changed later as well.
Merged #3534 into master.
Thanks @henningw!