19 Apr
2017
19 Apr
'17
2:43 p.m.
- changed separator because if IPv6 addresses were to be saved in a db_text file, their
format would upset the parser
I think that 4.4 would also benefit by back-porting this. Agree?
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1078
-- Commit Summary --
* db_text: change field separator from ":" to "|"
-- File Changes --
M src/modules/db_text/dbt_lib.h (2)
M src/modules/db_text/doc/db_text_admin.xml (18)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1078.patch
https://github.com/kamailio/kamailio/pull/1078.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1078
19 Apr
19 Apr
2:45 p.m.
@lbalaceanu dbtext escapes the `:`, i don't see the need for this and it will break
existing deployments. you can however put the delimiter in a module parameter. thoughts ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1078#issuecomment-295257004
3 p.m.
I agree with @lazedo -- this should be a modparam if you prefer to use a different
separator. There are some modules using `|` in some of their columns (iirc, drouting), but
at the end any character can appear in the values and they must be escaped.
I understand that one could prefer a different separator to make it more convenient to
work directly with the dbtext files, but this has to be configurable and still have `:` as
default separator because there are many deployments out there using existing separator.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1078#issuecomment-295261461
3:10 p.m.
Hi guys,
You are right, I will make the parameter configurable.
Thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1078#issuecomment-295264186
24 Apr
24 Apr
9:14 a.m.
Updated code in the merge branch. If this also looks good to you I will close the merge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1078#issuecomment-296551283
11:16 a.m.
Thanks! It is ok to merge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1078#issuecomment-296590125
1:08 p.m.
Merged #1078.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1078#event-1054541266
2748
days inactive
2753
days old
6 comments
3 participants
participants (3)
-
Daniel-Constantin Mierla -
lazedo
-
Lucian Balaceanu