In the XAVPVIAFIELDS block there is the string written to the wrong variable.
The string is stored in _ksr_xavp_via_params.s but the lenght is stored in
_ksr_xavp_via_fields.len. This breaks XAVPVIAPARAMS and XAVPVIAFIELDS.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x
...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes
that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines
from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on
sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that
apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
`via_use_xavp_fields("1");` and probably
`via_add_xavp_params("1");` are broken because of a typo in parsing the
xavp names. The values of xavp_via_params global parameter and xavp_via_fields global
parameter are not stored correctly.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3540
-- Commit Summary --
* core: cfg.y typo in parsing XAVPVIAFIELDS
-- File Changes --
M src/core/cfg.y (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3540.patch
https://github.com/kamailio/kamailio/pull/3540.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3540
You are receiving this because you are subscribed to this thread.
Message ID: &lt;kamailio/kamailio/pull/3540(a)github.com&gt;