2 Oct
2018
2 Oct
'18
1:05 p.m.
Got this today with latest master:
CC (gcc) [M sdpops.so] sdpops_mod.o
sdpops_mod.c: In function 'sdp_get_sess_version':
sdpops_mod.c:1871:14: warning: unused variable 'sdp' [-Wunused-variable]
sdp_info_t *sdp = NULL;
^~~
It would be nice if people who make commits would try to compile the
code first.
-- Juha
2 Oct
2 Oct
1:20 p.m.
On 02.10.18 12:05, Juha Heinanen wrote:
Got this today with latest master:
CC (gcc) [M sdpops.so] sdpops_mod.o
sdpops_mod.c: In function 'sdp_get_sess_version':
sdpops_mod.c:1871:14: warning: unused variable 'sdp' [-Wunused-variable]
sdp_info_t *sdp = NULL;
^~~
It would be nice if people who make commits would try to compile the
code first.
It is a matter of the OS, compiler and version if this kind of warning
is shown with the default flags. For example clang doesn't show it.
Latest versions of gcc do it.
Also, the code is compiled by travis-ci, so if there is a compile error,
there will be an email alert on the sr-dev list.
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference -- www.kamailioworld.com
Kamailio Advanced Training, Nov 12-14, 2018, in Berlin -- www.asipto.com
1:26 p.m.
Daniel-Constantin Mierla writes:
It is a matter of the OS, compiler and version if this
kind of warning
is shown with the default flags. For example clang doesn't show it.
Latest versions of gcc do it.
If clang does not show it, then the compile test should be done with
gcc. It is very bad policy if Kamailio project allows compiler warnings
in the source code.
Also, the code is compiled by travis-ci, so if there
is a compile error,
there will be an email alert on the sr-dev list.
I don't know if travis-ci warns about unused variables. If not, then
it is useless in this regard.
-- Juha
1:37 p.m.
My remark was in context of your remark "It would be nice if people who
make commits would try to compile the code first." I am sure that Mikko
compiled and more than that it was made via a pull request, which was
compiled again by travis.
When making a stable release, it is cleaned up as much as possible from
warnings, also via coverity scan and static analysis. Among warnings,
unused variable is harmless and most compilers don't show it. Again, if
you use latest debian, you are seeing it, but older version of debian,
bsd, mac os, centos ... do not show it.
Cheers,
Daniel
On 02.10.18 12:26, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference -- www.kamailioworld.com
Kamailio Advanced Training, Nov 12-14, 2018, in Berlin -- www.asipto.com
It is a matter of the OS, compiler and version if
this kind of warning
is shown with the default flags. For example clang doesn't show it.
Latest versions of gcc do it.
If clang does not show it, then the compile test
should be done with
gcc. It is very bad policy if Kamailio project allows compiler warnings
in the source code.
Also, the code is compiled by travis-ci, so if
there is a compile error,
there will be an email alert on the sr-dev list.
I don't know if travis-ci
warns about unused variables. If not, then
it is useless in this regard.
-- Juha
4:46 p.m.
Hi Juha
Thanks for the feedback.
Looks like -Wall was not enabled on clang, I should have noticed that long time ago.
I just enabled -Wall locally and try to see if anything interesting
comes up that I could help fix.
--
Mikko
4:52 p.m.
Mikko Lehto writes:
Thanks for the feedback.
Looks like -Wall was not enabled on clang, I should have noticed that long time ago.
I just enabled -Wall locally and try to see if anything interesting
comes up that I could help fix.
Mikko,
Thank you very much. Clean compilation avoids the need to manually scan
the warnings in order to determine, which ones are potentially harmful.
-- Juha
2275
days inactive
2275
days old
5 comments
3 participants
participants (3)
-
Daniel-Constantin Mierla -
Juha Heinanen -
Mikko Lehto