19 Nov
2021
19 Nov
'21
5:33 a.m.
In acquire_spi, making condition of acquiring the releasing lock aligned.
Fixes #2939
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2941
-- Commit Summary --
* Fix a possible deadlock bug due to unreleased lock
-- File Changes --
M src/modules/ims_ipsec_pcscf/spi_gen.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2941.patch
https://github.com/kamailio/kamailio/pull/2941.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2941
19 Nov
19 Nov
9:21 a.m.
Thanks for the pull request. I am not 100% sure if this approach is the right one.
* in line 83 the lock is allocated, sure
* the while loop basically has two exit conditions
* there are no free SPIs - first unlock, line 109
* a free SPI was found - second unlock, line 121
Your pull request changes this logic to unconditionally unlock, and then do a second
unlock again, if I am not wrong?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2941#issuecomment-973817111
11:04 a.m.
My observation is that because the lock is acquired first (Line83) so the lock should be
safely released before returning.
https://github.com/kamailio/kamailio/blob/1ddc27f199061025a6a43da3e8a1388fc…
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2941#issuecomment-973884476
11:10 a.m.
I've missed the missing braces around the if condition, right. Let me have another
look at the logic later today.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2941#issuecomment-973889036
11:14 a.m.
There is an build error reported from the auto-build, maybe you can have a look.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2941#issuecomment-973891722
11:15 a.m.
Closed #2941.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2941#event-5644024323
11:17 a.m.
@henningw Thank you for your time.
The code can always ensure that the lock is released at line 109 before returning.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2941#issuecomment-973893867
1130
days inactive
1130
days old
6 comments
2 participants
participants (2)
-
Henning Westerholt -
ryancaicse