<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Move pinging of rtpengines outside locks, by making a pkg copy of the list. Update shm list afterwards, under locks.
Basically tested by doing "kamcmd rtpengine.reload" while the timer was pinging the rtpengines. More testing will come. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4305
-- Commit Summary --
* rtpengine: timer ping nodes outside locks
-- File Changes --
M src/modules/rtpengine/rtpengine.c (121)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4305.patch https://github.com/kamailio/kamailio/pull/4305.diff
stefan-mititelu-idt left a comment (kamailio/kamailio#4305)
@xkaraman maybe you can have a look on this one too. This obsoletes the PR #4295. Thanks in advance.
xkaraman left a comment (kamailio/kamailio#4305)
Since this is an improvement, it wont' obselete PR #4295 which is a bug fix and may be backported if need.
Other than that, it might need some more review by other as well.
henningw left a comment (kamailio/kamailio#4305)
PR #4295 was merged, as it also needs backporting to some stable branches.
After the merge this PR now has a conflict (obviously), so it probably needs to be updated.
@stefan-mititelu-idt pushed 1 commit.
66d0fffb27bd286760f18ac51b42f3ab3549c0b6 rtpengine: timer ping nodes outside locks
stefan-mititelu-idt left a comment (kamailio/kamailio#4305)
Thanks, rebased into latest upstream/master and solved small conflict.
henningw left a comment (kamailio/kamailio#4305)
@stefan-mititelu-idt Thank you. Quick question about the general status, is this still in testing from your side or do you consider its done for review and later merging from your side?
stefan-mititelu-idt left a comment (kamailio/kamailio#4305)
This is ready for review. No issues spotted so far during testing.