#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3497
-- Commit Summary --
* sipcapture: use memcpy instead of strncpy for coherence * rtpproxy: use memcpy instead of strcpy for coherence
-- File Changes --
M src/modules/rtpproxy/rtpproxy.c (40) M src/modules/sipcapture/sipcapture.c (16)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3497.patch https://github.com/kamailio/kamailio/pull/3497.diff
@linuxmaniac pushed 1 commit.
1edf22c025aeef5698d154b192cf985d6071f77f path: use snprintf() instead of sprintf()
@linuxmaniac pushed 2 commits.
bcdce041c1f4b0a9cb1c40aee7008c113c2d952a permissions: use strncpy() for setting boundaries fc4de03af89c85edb1246731c65e2d618fc21b59 core: socket_info use strncpy() for setting boundaries
@linuxmaniac pushed 6 commits.
f8091c4e884e71e95b1d250b67f525da0af42c0f sipcapture: use memcpy instead of strncpy for coherence 7af111e89a02a66ba0de916c27dbdbeec54725f1 rtpproxy: use memcpy instead of strcpy for coherence 507d2d29c84a5490a05a98d855e3c71d655fa168 path: use snprintf() instead of sprintf() 995dc2ec66295de80e5213922ccc3e4517863658 permissions: use strncpy() for setting boundaries 4e76ef52393e954881ead87359c8828dd18ab1b6 core: socket_info use strncpy() for setting boundaries 98d1c4f03e6fe128ee1b962c47429e95d3a8e57f jsonrcps: use strncpy() for setting boundaries
@linuxmaniac pushed 7 commits.
197080f484c8af2d1e46d989a6315f0d736c9d33 sipcapture: use memcpy instead of strncpy for coherence 74d8e5044d6718bf5986378be020575a8ef09693 rtpproxy: use memcpy instead of strcpy for coherence f813fed5a6888042593f5c63cc709493ea03feed path: use snprintf() instead of sprintf() 2091b1ef2d4a09e9bfcb431abccf6087267953c4 permissions: use strncpy() for setting boundaries 6ca9384b2207e97a2fac08ba3ac6ab8e881351b9 core: socket_info use strncpy() for setting boundaries 56a8a30aeb9fdd4753c905ce1b6591b29ddde8ba jsonrcps: use strncpy() for setting boundaries b8263c65e45c8ffca0cfca4b901dc0c55c3eb825 core: modparam use strncpy() for setting boundaries
@linuxmaniac pushed 26 commits.
2dbaa727a38e29da0f887fa5d0d8d20392839f9b tm: remove obselete comment, add clarification for reply_wait mode 2 498e9f7276459b3f3963544527d9bd2ae5d36e40 ims_qos: remove not needed function name prefix from log message (related to GH #3503) 883f6b77211a76b35a9df570a8ddbbc344b05472 kex: safety checks when iterating stats list b1356efd61e56eaa3426d8e2e813ea6730b4f2c9 registrar: increase max size for user and domain building aor 7827013c50121b5d085dc3352b44aad940460513 msilo: reformat exports structures for better alignment 3542608f89dba934d943c3de8b66e178c0cecdc5 msilo: new function to allow specifying src/dst addresses 8da60f5a0a55fa2d5bb084b8215b96ec4c032161 msilo: docs for m_store_addrs() 7ca151a0479e4971980f4bbbc10cbd8f7deea1b6 modules: readme files regenerated - msilo ... [skip ci] cdd6b960f4cfea2fa8a2f5f79750568d8c49d89f msilo: exppose callid and status columns as params to match db schema 38514a77aea446e36ba5ce2db32d0c4ae57571ed msilo: docs for parms to set column names for callid and status 8ada99e8c686db639ee73a6584816c3fe0096b6d msilo: option to store call-id and reuse it on delivery 917b608f958e9a7a68388d8b53630cdf9cb2f3b1 msilo: docs for use_mode parameter 5da9ba4c12161ac864022b1624faef6c16777b4f modules: readme files regenerated - msilo ... [skip ci] 874351c0d4bc4e8fce5dd9f3ca617e8c3b61ef89 imc: reformat initialized structures ce3b16565a3375c4fcdabb39bfbd0c814f402da9 imc: added function to check if a room is active 4d0459545ada92786d3d7ee1f9aeefd82c8527e7 imc: docs for imc_room_active() function 9fd006e48469d86f68926418fc749cb798fdc9b7 modules: readme files regenerated - imc ... [skip ci] e17a3de2994e3237ea4a0916f60635f9f038d266 nats: nats_publish set reply parameter to be optional cbd7810fff3d5145c1ce34c0e362b5590bb92a12 sipcapture: use memcpy instead of strncpy for coherence d00ceda2c0428c6c02f3ed6d4c8c067e3f6ae94b rtpproxy: use memcpy instead of strcpy for coherence dd04bceb99ba69bd59c67ba103f3c55d47a31dd6 path: use snprintf() instead of sprintf() 77ca2e93e945fe46783e953d58bc546d9d6d1b81 permissions: use strncpy() for setting boundaries e347d89dba284f2d9635828b10b7ed49ad2244ad core: socket_info use strncpy() for setting boundaries 7e8a70e9bf3d0b52eae1b7933633095686f234b2 jsonrcps: use strncpy() for setting boundaries 675f6c0224897544d30f5f863c503499b2e5f2fe core: modparam use strncpy() for setting boundaries f9eb523eff1a4ea316c92d2061b5c5e36ff77b60 ctl: use snprintf() to set boundaries
It can be merged if no other changes are planned inside this PR -- it is ageing and it can result in conflicts in the future, another PR can be created for similar changes.
Merged #3497 into master.
-
Daniel-Constantin Mierla -
Victor Seva