#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1315
-- Commit Summary --
* core: removing the condition for second record_route ipv6 header
-- File Changes --
M src/core/msg_translator.c (9)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1315.patch https://github.com/kamailio/kamailio/pull/1315.diff
@miconda please review this also for record_route header
Do you have advertise address to the listen socket?
I just pushed another patch (referenced above), because there were other cases when the same condition was used. The new patch is taking a safer path by checking if the ipv6 address starts with `[`.
Can you test and report if ok?
@miconda yes ,i have advertise address to the listen socket.
@miconda i will test the same.we are expecting all ipv6 patch to be merged with stable branch so we can start using those only.
If testing with master is ok, then I will backport. Just report if it works fine or not.
@miconda i tested with master branch.its working fine.it will be good if you can commit all changes related to ipv6 to all stable releases specially to 5.x.x branches.reference to following pull request: https://github.com/kamailio/kamailio/pull/1319 https://github.com/kamailio/kamailio/pull/1315 https://github.com/kamailio/kamailio/pull/1291
Closed #1315.
Patches should be backported by now in the 5.x.x branches, if you still find an issue, open another item on the tracker.
@miconda thanks.