<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2273
-- Commit Summary --
* siptrace: don't check if trace is off in ack for negative replies callback * siptrace: trace incoming CANCEL into a dedicated callback * siptrace: don't trace CANCEL if the cancelled transaction is already being traced * siptrace: skip sip_trace for ACK for negative replies if the original transaction is already being traced
-- File Changes --
M src/modules/siptrace/siptrace.c (102)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2273.patch https://github.com/kamailio/kamailio/pull/2273.diff
You can go ahead and merge it.
I am thinking that it could make sense to add some dedicated functions to the TM module and TM API to get only the needed fields from a transaction, not to have to backup active transaction, lookup the one we need for checking and then restoring to the old one, as long as we do not need to do any other operation with the searched transaction. But this only as a future enhancement (the idea popped up a while ago, for some other parts of the code, but could be used here as well).
Agree that such functions could be very useful in cases like this one. Should I backport to 5.3?
Merged #2273 into master.