Hello all,
The way sipcapture now works, for requests it inserts the actual method name into the "method" field. But for replies, it inserts the SIP Status (i.e. 200, 407) into the "method" field.
It would be better to extract the actual method name from the CSEQ header and insert it into the "method" field, as well as adding a "status" field to the tables and inserting there the actual SIP Status.
I've made a patch for sipcapture.c and sipcapture.h which do just that. I will also be submitting a PR to homer for this, as db tables need to be modified to accept the status field.
How do i do the pull request?
I don't seem to be allowed to do commits to a branch i created locally
Regards,
Regards,
David Villasmil email: david.villasmil.work@gmail.com https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=david.villasmil.work@gmail.com phone: +34669448337
+1 for the improvement initiative, I've found myself sometimes doing those kind of queries with SQL... :|
David Villasmil david.villasmil.work@gmail.com wrote:
How do i do the pull request?
I don't seem to be allowed to do commits to a branch i created locally
Do you have your branch in Github? Maybe you just need to say something like "git push origin sipcapture_enhancement_branch"
When branch is visible in Github web, try loading branch specific page¹ and then select "Compare". That should bring you the pull request dialog.
[1] Something like https://github.com/your_account/kamailio/tree/sipcapture_enhancement_branch"