[kamailio/kamailio] support pkg-config when detecting libxml2 (#2199)

List overview All Threads
Download

newer

older

git: new commits in branch 5.3

git:master:0fff35bd: usrloc: fix...

Victor Seva

22 Jan 2020 22 Jan '20

8:28 a.m.

...

From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=949521: your package is using `xml2-config` to detect and use libxml2. I'm

removing that script, so please update your build system to use pkg-config instead.

...

Additionally, your package is not failing to build, so it's creating

binaries that are not linked against libxml2 anymore:

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199

Attachments:

attachment.html (text/html — 1.9 KB)

Show replies by date

Daniel-Constantin Mierla

22 Jan 22 Jan

8:38 a.m.

Anyone knowing if pkg-config for libxml2 available on all common distros, so we can remove its usage completely, or just go and try first pkg-config and let xml2-config as a fallback?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199#issuecomment-577068318

Victor Seva

8:39 a.m.

I will go for try first pkg-config and let xml2-config as a fallback since that change is going to be just in newer versions.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199#issuecomment-577068901

sergey-safarov

8:44 a.m.

This dist already have `pkg-config` 1. CentOS 1. RHEL 1. Fedora 1. OpenSUSE 1. Oracle Linux 1. Alpine Linux

So we can leave only pkg-config case.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199#issuecomment-577071039

Daniel-Constantin Mierla

8:55 a.m.

@sergey-safarov - also older versions, not only current stable?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199#issuecomment-577075330

Daniel-Constantin Mierla

9:01 a.m.

I see that 26 modules use it in Makefile.

On the other hand, on macos, the output of xml2-config and pkg-config are different:

``` $ xml2-config --libs -L/opt/local/lib -lxml2 -L/opt/local/lib -lz -L/opt/local/lib -llzma -lpthread -liconv -L/opt/local/lib -licui18n -licuuc -licudata -lm

$ which xml2-config /opt/local/bin/xml2-config

$ pkg-config --libs libxml-2.0 -L/opt/local/lib -lxml2

$ which pkg-config /opt/local/bin/pkg-config ```

On debian 10 is the same.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199#issuecomment-577077983

sergey-safarov

9:15 a.m.

Oldest `RHEL-6` based dist (CentOS-6, Oracle Linux 6) is have `pkgconfig-0.23-9` and `libxml2-2.7.6` ``` [root@8760520b12b8 /]# cat /usr/lib64/pkgconfig/libxml-2.0.pc prefix=/usr exec_prefix=/usr libdir=/usr/lib64 includedir=/usr/include modules=1

Name: libXML Version: 2.7.6 Description: libXML library version2. Requires: Libs: -L${libdir} -lxml2 Libs.private: -lz -lm Cflags: -I${includedir}/libxml2 ```

For oldest OpenSUSE `pkg-config-0.28-11` and `libxml2-devel-2.9.4` ``` 52640dd1687d:/ # cat /usr/lib64/pkgconfig/libxml-2.0.pc prefix=/usr exec_prefix=/usr libdir=/usr/lib64 includedir=/usr/include modules=1

Name: libXML Version: 2.9.4 Description: libXML library version2. Requires: Libs: -L${libdir} -lxml2 Libs.private: -L/lib64 -lz -llzma -lm Cflags: -I${includedir}/libxml2 ```

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199#issuecomment-577083690

Henning Westerholt

3 Feb 3 Feb

3:31 p.m.

Do we have any conclusion here, should we go this way:

...

I will go for try first pkg-config and let xml2-config as a fallback since that change is going to be just in newer versions.

and about the MacOS - maybe the compilation will also work with the fewer flags, I can't test it though.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199#issuecomment-581469790

Daniel-Constantin Mierla

5 Feb 5 Feb

8:06 p.m.

I think the best would be to figure out first if `xml2-config` exists and if yes, use it, otherwise look for `pkg-config`. I expect `xml2-config` comes from developers of the project, while `pkg-config` is more a distro/packager variant, but the main argument would be that currently it works fine with `xml2-config`. If some distro has no longer `xml2-config`, then `pkg-config` will be used anyhow.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199#issuecomment-582587839

Daniel-Constantin Mierla

13 Feb 13 Feb

9:32 a.m.

Master should have all the mods updated. If someone prefers a different way, let's discuss further.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199#issuecomment-585634123

Daniel-Constantin Mierla

9:32 a.m.

Closed #2199.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199#event-3034072556

Victor Seva

11 May 11 May

12:22 p.m.

can We backport this changes to 5.3?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199#issuecomment-626667878

Daniel-Constantin Mierla

12:25 p.m.

Sure

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199#issuecomment-626669306

1798

Age (days ago)

1908

Last active (days ago)

sr-dev@lists.kamailio.org

12 comments

4 participants

tags (0)

participants (4)

Daniel-Constantin Mierla
Henning Westerholt
sergey-safarov
Victor Seva