On 14/10/14 16:42, Juha Heinanen wrote: set_contact_alias() is doing what those limitations are in add_contact_alias(). From 'external' SIP singaling point of view, same change is seen in the SIP packets. The difference is how the change is done internally. - add_contact_alias() is adding/removing pieces of string in existing contact, the old value is seen by any other module needed to store the contact (e.g., dialog, presence) and they won't work if are used in a Kamailio positioned as the first hop after nat router - set_contact_alias() is building the new contact and replaces the old one at once, with some special internal flag that makes it visibile immediately (same flag is used by fixed_nated_contact()) In other words, add_contact_alias() can be pointed directly to set_contact_alias() and no functionality is lost. Ovidiu's suggestion is to deprecate it and remove it in future version. I don't have any strong opinion on any option: it can be kept and pointed to set_contact_alias() or removed in the future. Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

On 14/10/14 17:13, Juha Heinanen wrote: I don't think it can be any real difference, not measured, though. set_contact_alias() replaced the fix_natted_contact() in default config, from this perspective I think that set_contact_alias() is used in more configs than add_contact_alias(), but at the end this is not the point, because you cannot really count all configs and anyhow usage count should not be reason to remove something better. The function was added in the same idea of having alternatives of fix_natted_contact() and add_contact_alias() tackling the same problem from a different point. On other words, as add_contact_alias() would prove to be better for handling nat traversal, we should rename it to fix_natted_contact() because that is older. If there is a strong desire to keep add_contact_alias(), it should be kept after all, but properly documented that has the limitations on making new contact visible and should not be used in a sip server instance used for presence, dialog, ... Or, even better in my opinion at this time, just point both to same C function. Overall, as this is discussion about deprecating something, it will happen more recently with the future next major release, 4.3. Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

On 14/10/14 17:44, Juha Heinanen wrote: Actually there were quite big implications in other modules (like in dialog done initially and then in tm module done recently to get it all work like a replacement for fix_natted_contact()) -- so it was not just about a new (or replacement) function in nathelper module. It's fine to keep add_contact_alias() from my point of view, if you feel it performs better for your needs (I didn't start this discussion after all), but docs have to list the limitations. I did say something about performances from my point of view in the previous email. Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

Ovidiu Sas writes: that is fine with me. add_contact_alias was intended to be used by a sip proxy, not one working as sip user agent. -- juha

Daniel-Constantin Mierla writes: understood. i have never had any problems with add_contact_alias, because i don't use dialog module (the one that historically has had more problems than any other kamailio module) and my sip proxy frontends my presence server. -- juha