11 Jan
2019
11 Jan
'19
6:17 p.m.
- send periodic tcp keepalive packets to server in order to prevent connection from
closing
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1808
-- Commit Summary --
* janssonrpcc: add new parameter "keep_alive"
-- File Changes --
M src/modules/janssonrpcc/doc/janssonrpcc_admin.xml (19)
M src/modules/janssonrpcc/janssonrpc_connect.c (56)
M src/modules/janssonrpcc/janssonrpc_server.h (1)
M src/modules/janssonrpcc/janssonrpc_srv.h (1)
M src/modules/janssonrpcc/janssonrpcc_mod.c (16)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1808.patch
https://github.com/kamailio/kamailio/pull/1808.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1808
11 Jan
11 Jan
7:28 p.m.
miconda commented on this pull request.
@@ -79,6 +82,11 @@ void
force_disconnect(jsonrpc_server_t* server)
server->buffer = NULL;
server->status = JSONRPC_SERVER_DISCONNECTED;
+ if (server->keep_alive_socket_fd) {
+ INFO("closing socket");
+ close(server->keep_alive_socket_fd);
+ server->keep_alive_socket_fd = -1;
+ }
I think that the condition above should be:
```
if (server->keep_alive_socket_fd>=0) {
```
otherwise it will be true after you close the socket and set the value of the field to -1.
So next time you will close fd -1, which is invalid.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1808#pullrequestreview-191765113
7:48 p.m.
eschmidbauer commented on this pull request.
@@ -79,6 +82,11 @@ void
force_disconnect(jsonrpc_server_t* server)
server->buffer = NULL;
server->status = JSONRPC_SERVER_DISCONNECTED;
+ if (server->keep_alive_socket_fd) {
+ INFO("closing socket");
+ close(server->keep_alive_socket_fd);
+ server->keep_alive_socket_fd = -1;
+ }
thanks! i've updated the PR
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1808#discussion_r247200881
13 Jan
13 Jan
2:05 p.m.
Can be merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1808#issuecomment-453824100
2:08 p.m.
Merged #1808 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1808#event-2070500780
2170
days inactive
2172
days old
4 comments
2 participants
participants (2)
-
Daniel-Constantin Mierla -
Emmanuel Schmidbauer