8 Mar
2017
8 Mar
'17
3:56 p.m.
As discussed on the mailing list and at FOSDEM this is a PR to start the discussion on the
support of SO_REUSEPORT.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1024
-- Commit Summary --
* core: enable reuse of tcp sockets
-- File Changes --
M src/Makefile.defs (3)
M src/core/cfg.lex (2)
M src/core/cfg.y (13)
M src/core/forward.h (40)
M src/core/tcp_main.c (20)
M src/core/tcp_options.c (3)
M src/core/tcp_options.h (1)
M src/modules/tm/uac.c (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1024.patch
https://github.com/kamailio/kamailio/pull/1024.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1024
14 Mar
14 Mar
10:34 p.m.
The patch is not that complex, so it can be merged, but I think there are few things to
add afterwards:
* find a way to have the option compiled always and enabled if available. Very unlikely
someone will re-compile with other define options. With a quick search, maybe uname()
(https://linux.die.net/man/2/uname) can be used to detect if the kernel is at least
version 3.9.0. Then still have the global kamailio.cfg parameter to enable/disable per
kamailio instance.
* make actual use of this capability -- probably that means ability to create more than
one tcp manager process that can listen on the same port and accept new connections
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1024#issuecomment-286535098
16 Mar
16 Mar
12:50 p.m.
Thanks for the feedback Daniel.
About the first point, I think that we still need the #define because if SO_REUSEPORT is
not defined for the running OS the compilation will fail. As far as I know the option is
currently supported in FreeBSD/OpenBSD/NetBSD/Mac OSX, not in Solaris. Maybe we could
conditionally add the define in Makefile.defs as it is done for other options depending
from the OS?
For the second point for the moment the two concrete usages I've found is for forcing
the sending socket in dispatcher and in the uac module, but for sure being able to create
additional tcp manager processes is much more interesting!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1024#issuecomment-287007367
1:15 p.m.
I think ifdef can be used to check if SO_REUSEPORT is defined, on macos:
```
/usr/include/sys/socket.h:136:#define SO_REUSEPORT 0x0200 /* allow local address &
port reuse */
```
On Linux:
```
/usr/include/asm-generic/socket.h:25:#define SO_REUSEPORT 15
```
So it appears it is a define when available.
The two use cases you listed are also important, I haven't thought of them, so I think
that if we can get it enabled at compile time based on availability (can be a follow up
commit), the PR can be merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1024#issuecomment-287013367
1:59 p.m.
@grumvalski pushed 1 commit.
d2c3f38 core: compile by default support for SO_REUSEPORT when available on the OS
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1024/files/78f0108a718a6a68321ff0…
2 p.m.
Just updated the PR with your suggestion.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1024#issuecomment-287024005
6:06 p.m.
Thanks, it can be merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1024#issuecomment-287086658
6:30 p.m.
Thank you, I will update the core to ad the new parameter.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1024#issuecomment-287094617
6:44 p.m.
Merged #1024.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1024#event-1002969820
2753
days inactive
2761
days old
8 comments
2 participants
participants (2)
-
Daniel-Constantin Mierla -
Federico Cabiddu