[kamailio/kamailio] ims_diameter_server: fix retrieval ``$diameter_response`` value (PR #4069)
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue https://lists.kamailio.org/mailman3/hyperkitty/list/sr-users@lists.kamailio....
#### Description ``current_msg_id_repl is only`` changed if ``$diameter_reponse`` is changed by via ``pv_set_response()``. The event_route is executed with a ``fake_msg`` so it will not match if is setted outside anyways.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4069
-- Commit Summary --
* ims_diameter_server: fix retrieval ``$diameter_response`` value
-- File Changes --
M src/modules/ims_diameter_server/avp_helper.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4069.patch https://github.com/kamailio/kamailio/pull/4069.diff
Hey Victor!
sorry, I tried to understand what's going on there, but I don't get it why the id of a sip_msg is used and how that relates to Diameter, so unable to help much. This code was probably contributed by @carstenbock and it seems to be a workaround to use Kamailio routing script for handling Diameter messages (albeit... due to the extensibility nature of Diameter, that might be a never-ending integration job of translating to JSON...). I'm reassigning to him.
IMHO all modules should have an assigned maintainer and we should have a rule to move orphaned ones to `src/modules.attic/` or something like that, which probably would drop them whenever a major Kamailio version is released and there are no upgrades done in time. If anyone misses and older module, they can revive it later, when they upgrade their core. Hope then keeping order would be easier.
Cheers, -Dragos
@linuxmaniac pushed 1 commit.
16b98255d6370ead22dc91a6404e404fc6ad5038 ims_diameter_server: fix retrieval ``$diameter_response`` value
The current message id is typically used to cache values or detect if values need to be recomputed.
I think this can be merged, based on the diff I could see in the PR.
Merged #4069 into master.
-
Daniel-Constantin Mierla -
Dragos Vingarzan
-
Victor Seva