10 May
2016
10 May
'16
1:44 p.m.
"Call completed elsewhere", RFC3326, defines this as the string to send.
Author: Frank Carmickle <frank(a)silentcircle.com>
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/610
-- Commit Summary --
* change answered elsewhere to call completed elsewhere
-- File Changes --
M modules/tm/t_cancel.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/610.patch
https://github.com/kamailio/kamailio/pull/610.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/610
11 May
11 May
8:01 a.m.
Thanks! I will apply the patch manually, as we do not push patched directly to stable
branches. They are pushed to master branch and then backported. Also, the commit message
needs to be prefixed with the component name, in this case "tm":
* https://www.kamailio.org/wiki/devel/github-contributions#commit_message_for…
I noticed that github allows now templates and other tools to highlight better the
contributing rules, but no time yet to work on.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/610#issuecomment-218439000
8:32 a.m.
The text is not normative in the RFC and it should not really matter - we should really
send the text sent in the 200 OK of the answer. The "200" code is the important
part - a SIP response code. the "Call completed elsewhere" text is part of the
examples in the RFC.
Do you have an implementation who parses reason texts?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/610#issuecomment-218445502
10:08 a.m.
@miconda I can update the patch.
@oej Yes, there are a few mobile implementations that strstr match several sip messages to
avoid fully parsing them.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/610#issuecomment-218470297
11:55 a.m.
@quentusrex: thanks, updating the patch will make the merge easier -- don't forget to
make it for master branch.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/610#issuecomment-218503749
12 May
12 May
12:03 p.m.
Closed #610.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/610#event-658805297
12:03 p.m.
Merged manually.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/610#issuecomment-218804391
3160
days inactive
3162
days old
6 comments
3 participants
participants (3)
-
Daniel-Constantin Mierla -
Olle E. Johansson
-
William King