<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> pkg/gentoo: Added ebuild files for versions 5.1.10, 5.2.6, 5.3.2 and master You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2220
-- Commit Summary --
* pkg/gentoo: Added ebuild files for versions 5.1.10, 5.2.6, 5.3.2 and
-- File Changes --
A pkg/kamailio/gentoo/files/kamailio.confd (14) A pkg/kamailio/gentoo/files/kamailio.initd (43) A pkg/kamailio/gentoo/kamailio-5.1.10.ebuild (153) A pkg/kamailio/gentoo/kamailio-5.2.6.ebuild (156) A pkg/kamailio/gentoo/kamailio-5.3.2.ebuild (155) A pkg/kamailio/gentoo/kamailio-9999.ebuild (162)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2220.patch https://github.com/kamailio/kamailio/pull/2220.diff
Thanks for the pull request. So it seems that there is no version inside the ebuild files. That means for minor releases they usually could just be copied or moved. I will merge them manually in the appropriate branches. There seems one small error in the license definition of the packages. You specify GPL-2, but I think it should be GPL-2+ (for the "or later" version, if I remember correctly).
Hi Henning,
GPL-2 is the license used by Gentoo Ebuilds and is standard.
For the package license we can add the row
LICENSE="GPL-2+" into the ebuilds theirselves to comply the Kamailio license if correct.
Kind regards.
Federico Santulli
Il giorno 16 feb 2020, alle ore 18:09, Henning Westerholt <notifications@github.com mailto:notifications@github.com> ha scritto:
Thanks for the pull request. So it seems that there is no version inside the ebuild files. That means for minor releases they usually could just be copied or moved. I will merge them manually in the appropriate branches. There seems one small error in the license definition of the packages. You specify GPL-2, but I think it should be GPL-2+ (for the "or later" version, if I remember correctly).
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/2220?email_source=notifications&email_token=ABO7UZPL6YJUQDL4NGAABWTRDFXKZA5CNFSM4KWDR7C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL4MQZI#issuecomment-586729573, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABO7UZIMOAAFH3AVC3UFFSTRDFXKZANCNFSM4KWDR7CQ.
Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org mailto:sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Federico Santulli
Federico Santulli
Thanks for the pull request. So it seems that there is no version inside the ebuild files. That means for minor releases they usually could just be copied or moved. I will merge them manually in the appropriate branches. There seems one small error in the license definition of the packages. You specify GPL-2, but I think it should be GPL-2+ (for the "or later" version, if I remember correctly).
Hi Henning,
GPL-2 is the license used by Gentoo Ebuild files.
For the package license we can add the proper row
**LICENSE="GPL-2+"**
into the ebuilds theirselves to comply the Kamailio license if correct.
Kind regards.
Federico Santulli
Ebuild files can be renamede to satisfy the "latest minor" but in case of dependency requirements they wont compile.
Thanks - yes I was referring to the Kamailio license. Ok, I can change this before the commit.
The 5.1 branch is end of official maintenance, not sure if it makes sense to add more to it, unless people want to have gentoo build for it, but so far was not required explicitely on mailing lists.
Then if the version is required in the file name, and we have to add/remove/rename files with each release, then better have 5.4.0 for master branch, rather than 9999.
Hi Daniel,
About the 5.1 release as i found a package i made an ebuild for it.
Btw, in the gentoo packaging system the 9999 version is used for git pull releases. Using static version 5.4.0 will require an archive to download and unpack.
I hope to be clear.
Kind regards
Federico Santulli
I've added the git master, 5.3 and 5.2 packages and files. For 5.1 I did not added it, as pointed out, this release is already EOL.
Closed #2220.