[kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)
9 Jun
2017
9 Jun
'17
8:21 a.m.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1150
-- Commit Summary --
* modules/topoh: added IP lookup functionality for trusted or untrusted destination
* modules/topoh: changed README
* utils/kamctl: fixed sql schema for topoh modules
-- File Changes --
M src/core/forward.h (5)
M src/modules/cfgt/cfgt_int.c (6)
M src/modules/corex/corex_nio.c (6)
M src/modules/dialog/dlg_cseq.c (6)
M src/modules/gzcompress/gzcompress_mod.c (6)
M src/modules/topoh/Makefile (2)
M src/modules/topoh/README (169)
A src/modules/topoh/address.c (395)
A src/modules/topoh/address.h (71)
M src/modules/topoh/doc/topoh.xml (12)
M src/modules/topoh/doc/topoh_admin.xml (197)
A src/modules/topoh/hash.c (454)
A src/modules/topoh/hash.h (165)
M src/modules/topoh/th_msg.c (1)
M src/modules/topoh/topoh_mod.c (69)
A src/modules/topoh/topoh_mod.h (42)
M src/modules/topos/topos_mod.c (9)
A utils/kamctl/db_sqlite/topoh-create.sql (11)
A utils/kamctl/dbtext/kamailio/topoh_address (2)
M utils/kamctl/dbtext/kamailio/version (1)
M utils/kamctl/kamctlrc (2)
A utils/kamctl/mysql/topoh-create.sql (11)
A utils/kamctl/oracle/topoh-create.sql (19)
A utils/kamctl/postgres/topoh-create.sql (11)
A utils/kamctl/xhttp_pi/topoh-table (11)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1150.patch
https://github.com/kamailio/kamailio/pull/1150.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150
9 Jun
9 Jun
8:43 a.m.
What is exactly the purpose of this new functionality? To allow/deny traffic from those IP
addresses or for doing/skipping topology hiding?
I am somehow not very pleased with importing a lot of code similar to what permissions
does in regards to address matching. I would rather do another approach that might bring
more flexibility as well, respectively to run an event route where one can run functions
from other modules and set some internal variable in order to control what topoh should do
after execution of the event block. This should not be something big in terms of new code,
I can do it in the next days if we agree on some concept that fits your needs.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-307378423
8:48 a.m.
Yes, exactly this way, just to exclude or include destination IP for topology hiding.
I am not sure that there is a way to do it via internal flags, because the event socket
for SREV_NET_DATA_OUT will be called from retransmission function in the tm module and in
this case you don't have sip_msg structure anymore.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-307379548
8:57 a.m.
We have the source code, we can change if something helps substantially -- currently, I
see two options that can be controlled via a mod param (or just choose one that it is
considered better):
* give a fake request, like it is done with other event_route blocks (e.g.,
htable:mod-init) -- this way should be very fast
* parse the outgoing buffer -- might be slightly slower, as it will parse even when not
doing topoh
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-307381336
9:04 a.m.
so, from topoh we can call topoh-route in kamailio.cfg , there we can use allow_address
from the permissions module and base on the result we can reject and accept topoh request.
Should we just send empty sip_msg structure there ? Just to avoid sip message parsing in
case the request will be rejected ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-307382832
9:39 a.m.
Giving a fake request is very fast, like done at:
* https://github.com/kamailio/kamailio/blob/master/src/modules/htable/htable.…
It is no parsing apart of the first time. This way is safe, because some functions need
the msg structure.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-307391182
9:45 a.m.
ok. agree.. this way will be more effective and flexible. Should I do or you wanna ? ;-)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-307392619
15 Jun
15 Jun
1:33 a.m.
I did an implementation to execute an event_route before the topoh processing for messages
to be sent out. Documentation will follow soon, meanwhile you can see the comments of the
commit f7d1d23 . Basically, $sndto(ip) should point to the ip address of the destination
and calling `drop` should skip topoh processing. I did no test with the new version, so
feedback and improvements are welcome.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-308633341
16 Jun
16 Jun
7:41 a.m.
Can this be used for topos as well as topoh?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-309004565
19 Jun
19 Jun
4:05 a.m.
Thank you @miconda , unfortunately there is bug that I couldnt catch.
6 days ago I have implemented same way in my repository:
https://github.com/adubovikov/kamailio/commit/ae15a717e9a5849b4ac295c5864cd…
but your and my patches makes same results:
/usr/sbin/kamailio[1260]: ERROR: sl [sl_funcs.c:362]: sl_reply_error(): stateless error
reply used: I'm terribly sorry, server error occurred (6/SL)
this is after execution of event route. I have tested/removed some code and found that
this happens once you call " fmsg = faked_msg_next();"
also in your patch:
https://github.com/kamailio/kamailio/commit/f7d1d234a42198fc10e40c33e92cff5…
should be:
if(_th_eventrt_outgoing<0 **&&** keng==NULL) {
any suggestions got to avoid this SL error ?
Wbr,
Alexandr
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-309368057
4:51 a.m.
Indeed, that condition should be with &&.
Is the next fake msg null, or what is failing there? Can you see what is the return code
for t_relay? I guess the slow error is because of sl_send_error () in kamaulio.cfg. I am
traveling, no much testing that I can do.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-309378578
4:56 a.m.
no, the fake msg is not null, but once you call the faked_msg_next(), after you will
always get "I'm terribly sorry, server error occurred (6/SL)", even if you
didn't execute "run_top_route".
I will check a bit more, but the issue it can be with pointer for re-transmission.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-309379606
10:32 a.m.
Might have been the execution of clear_branches() inside next faked msg function, which
was resetting some global variables. I just pushed a patch in master, can you give it a
try again?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-309457952
1:36 p.m.
bingo! :-)
now another issue:
/usr/sbin/kamailio[1798]: ERROR: topoh [topoh_mod.c:560]: th_execute_event_route(): exit
due to 'drop' in event route
/usr/sbin/kamailio[1798]: : <core> [core/mem/q_malloc.c:469]: qm_free(): BUG:
qm_free: bad pointer 0x7fa3461b9000 (out of memory block!) called from core:
core/parser/msg_parser.c: reset_new_uri(720) - aborting
CRITICAL: <core> [core/pass_fd.c:277]: receive_fd(): EOF on 16
and I don't have anything in core:
(gdb) bt full
#0 0x00007f69d1059067 in ?? ()
No symbol table info available.
#1 0x00007f69d105a448 in ?? ()
No symbol table info available.
#2 0x0000000000000020 in ?? ()
No symbol table info available.
#3 0x0000000000000000 in ?? ()
No symbol table info available.
(gdb) quit
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-309512126
20 Jun
20 Jun
3:52 a.m.
https://github.com/kamailio/kamailio/pull/1155
looks like it has been fixed :-)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-309673679
3:56 a.m.
So #1155 is fixing also the introduced bug with bad pointer?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-309674524
4 a.m.
yep. It works now! :-) thank you
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-309675518
4:03 a.m.
Thanks, closing it then!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#issuecomment-309676278
4:03 a.m.
Closed #1150.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1150#event-1130489809
2570
days inactive
2581
days old
18 comments
3 participants
participants (3)
-
Alexandr Dubovikov -
Anthony Messina
-
Daniel-Constantin Mierla