<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
Adding sqlfile ims i-cscf to utils/kamctl/mysql copied from misc/examples/ims/icscf so that sql file will be automatically included in kamailio-mysql-module packages in the future You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3876
-- Commit Summary --
* IMS DB: Adding i-cscf database/tables under utils/kamctl/mysql
-- File Changes --
A utils/kamctl/mysql/ims-icscf.sql (94)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3876.patch https://github.com/kamailio/kamailio/pull/3876.diff
I am fine to merge it, although it would be good that ims-related tables get the corresponding xml schema definitions in the `src/lib/srdb1/schema/` and be generated from there.
This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.
@markusmonka Any plans to maybe also add the XML schema definitions as mentioned above?
in a quiet minute i like to watch it
This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.
Xenofon will have a look to it and convert it to XML files.
Closed #3876.
Thanks for the PR, it will be implemented with the linked PR in the XML schema, close this one.