During re-registration, Diameter SAR message is sent to the HSS. It contains User-Data-Already-Available AVP, which by specification (TS 29.228, Table 6.1.2.1) instructs the HSS not to send subscription data. However when SAA is received without User-Data an error is generated. I think this behavior is not correct.
This patch modifies SAA handling so it doesn't try to update local ims subscription information, for the case where there is none received from the HSS. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/630
-- Commit Summary --
* ims_registar_scscf: Fix subscr data handling in SAA
-- File Changes --
M modules/ims_registrar_scscf/cxdx_sar.c (23)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/630.patch https://github.com/kamailio/kamailio/pull/630.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/630
Thanks!
Patch is slim, but maybe @jaybeepee, @richardgood or @ngvoice want to have a look and comment. If all is ok, any can do the merge.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/630#issuecomment-220934321
Hi,
you are right, it's not correct. I will test & review the patch later today.
Thanks, Carsten
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/630#issuecomment-220943459
Thanks @tdimitrov - looks fine!
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/630#issuecomment-220943485
Merged #630.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/630#event-668761202
You're welcome, I'm glad I can help!
Is it possible merge this patch in 4.3 and 4.4 branches too?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/630#issuecomment-221299963
-
Daniel-Constantin Mierla -
jaybeepee
-
ng-voice GmbH
-
Tsvetomir Dimitrov