Module: kamailio Branch: master Commit: 063e6a025b8ca0163af2147f057d29447c6f9760 URL: https://github.com/kamailio/kamailio/commit/063e6a025b8ca0163af2147f057d2944...
Author: Henning Westerholt hw@skalatan.de Committer: Henning Westerholt hw@skalatan.de Date: 2019-11-23T22:49:28+01:00
core: increase SHM memory pool to 128 MB
- increase SHM memory pool to 128 MB - even an embedded system like Raspberry Pi has 1 GB RAM nowadays - make it less likely that new users run into issues because of lack of memory
---
Modified: src/core/config.h
---
Diff: https://github.com/kamailio/kamailio/commit/063e6a025b8ca0163af2147f057d2944... Patch: https://github.com/kamailio/kamailio/commit/063e6a025b8ca0163af2147f057d2944...
---
diff --git a/src/core/config.h b/src/core/config.h index 0eda20302b..96196a0224 100644 --- a/src/core/config.h +++ b/src/core/config.h @@ -142,7 +142,7 @@ #endif #define PKG_MEM_POOL_SIZE PKG_MEM_SIZE*1024*1024 /*!< used only if PKG_MALLOC is defined*/
-#define SHM_MEM_SIZE 64 /*!< used if SH_MEM is defined*/ +#define SHM_MEM_SIZE 128 /*!< used if SH_MEM is defined*/ #define SHM_MEM_POOL_SIZE SHM_MEM_SIZE*1024*1024
/* dimensioning buckets in q_malloc */
Hello,
On 23.11.19 23:23, Henning Westerholt wrote:
Module: kamailio Branch: master Commit: 063e6a025b8ca0163af2147f057d29447c6f9760 URL: https://github.com/kamailio/kamailio/commit/063e6a025b8ca0163af2147f057d2944...
Author: Henning Westerholt hw@skalatan.de Committer: Henning Westerholt hw@skalatan.de Date: 2019-11-23T22:49:28+01:00
core: increase SHM memory pool to 128 MB
- increase SHM memory pool to 128 MB
- even an embedded system like Raspberry Pi has 1 GB RAM nowadays
- make it less likely that new users run into issues because of lack of memory
I am curious about the last remark, can you priovide more details on issues for new uses because lack of memory? I haven't noticed and such report on mailling lists or issue tracker later, whondering if it is some particular use case that can lead to this issue.
Because a start of kamailio with default config file is using less than 3MB of shared memory, being plenty of space to fill up to 64MB with registrations, transactions, etc... states taken a few minutes ago with git master branch:
"shmem:max_used_size = 2836288", "shmem:real_used_size = 2836288", "shmem:used_size = 2594376"
Then, my actual remark is that I think the new users tend to use the packages, which use init.d/systemd to start kamailio, and there are values for pkg and shm sizes in the unit files, so this change doesn't really make a difference, because kamailio is started with different -m and -M command line parameters.
Cheers, Daniel
[...]
Hi Daniel,
from time to time there are reports that people run into issues after trying to load larger data sets into the memory (e.g. with routing tables).
I also thought about the system package files, if its ok I would also check them to increase it as well to 128 MB.
Cheers,
Henning
Hello,
On 25.11.19 20:57, Henning Westerholt wrote:
Hi Daniel,
from time to time there are reports that people run into issues after trying to load larger data sets into the memory (e.g. with routing tables).
As I said, I haven't noticed any such report and actually I just searched now on site:lists.kamailio.org for the past year and I couldn't find anything.
I also thought about the system package files, if its ok I would also check them to increase it as well to 128 MB.
Personally I didn't meet any case lately where the default value has to be changed for shm and the defaults should be for the avearage use of Kamailio -- that's the reason I wanted to know about some of these cases.
I do not want to get Kamailio look greedy in resources because the defaults are tuned for corner cases. I did increase many of the internal buffers/sizes whenerver there were related reports, but didn't noticed the default shm is even getting closer to being filled up for new comers playing with kamailio.
If there is a need for such increase for new comers, I would rather keep the default in the source code lower and increase it in startup scripts. Who starts from command line is expected to have some knowledge about its parameters, easily set the -M and -m.
Cheers, Daniel
Hi Daniel,
I don't think that anybody might think that Kamailio is greedy with resources. A Raspberry Zero for 5 Dollar has 512 MB RAM and was released in 2015.
Some years ago we also increased PKG memory default for similar reasons, so I think this is a reasonable change after all the years as well.
Cheers,
Henning
Hello,
On 26.11.19 21:28, Henning Westerholt wrote:
Hi Daniel,
I don't think that anybody might think that Kamailio is greedy with resources.
If you start an application and demands a lot of memory without doing anything, then people associated it with a resource greedy application, like they did with Java or Electron based apps.
A Raspberry Zero for 5 Dollar has 512 MB RAM and was released in 2015.
There are a lot of deployments out there that still run on old but reliable (and expensive) hardware like IBM/HPE/Dell blades. You comparison is not applicable, you look at the cheap consumer harware, not what is actually out there in production environments.
Some years ago we also increased PKG memory default for similar reasons,
At that moment there was a discussion about it debating the necessity:
commit 2376ef7c6f3317054c844ae9b99366d084065121 Author: Daniel-Constantin Mierla miconda@gmail.com Date: Thu Oct 2 09:48:36 2014 +0200
core: default pkg memory size set to 8MB
- as per discussion on mailing lists
so I think this is a reasonable change after all the years as well.
So it ends up being just your personal opinion, as I couldn't find any evidence this change is actually needed. I do not find reasonable any change to default allocated resources without proper grounds.
Not long time ago you published a blog post on high capacity/performances of kamailio on raspberry pi, iirc, there was with default config and no command line tunings, so I expect it was with the defaults -- given that, 5000 registrations/second and 300 call setups per second is more than what 90% of telefony systems deal with. This change somehow contradicts it.
Cheers, Daniel
-
Daniel-Constantin Mierla -
Henning Westerholt