<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
ims_auth: option to generate authentication vector locally, without needed CDP and HSS.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4054
-- Commit Summary --
* ims_auth: added Milenage, AES-128 (Rijndael) and auth_vector local generation * ims_auth: new av_mode parameter * ims_auth: synced functions with number of parameters * ims_auth: function to set ims auth data * ims_auth: reworked the local AV API * ims_auth: generate local auth vector when none is found for challenge * ims_auth: fixed compilation and moved back auth_vector to authorize.h * ims_auth: integrated local resync * ims_auth: dropped all old vectors on local resync * ims_auth: docs for av_mode parameter * ims_auth: relocated aes128.{c,h} to gcrypt module * gcrypt: exported api for aes128 functions * gcrypt: include file for binding module exports * ims_auth: use gcrypt api for aes128 functions * ims_auth: don't bind or use cdp when av_mode is 1 * ims_auth: docs updated with gcrypt dependency
-- File Changes --
A src/modules/gcrypt/api.h (66) A src/modules/gcrypt/gcrypt_aes128.c (109) A src/modules/gcrypt/gcrypt_aes128.h (33) M src/modules/gcrypt/gcrypt_mod.c (21) A src/modules/ims_auth/auth_vector.c (144) A src/modules/ims_auth/auth_vector.h (36) M src/modules/ims_auth/authorize.c (357) M src/modules/ims_auth/authorize.h (24) M src/modules/ims_auth/cxdx_mar.h (2) M src/modules/ims_auth/doc/ims_auth_admin.xml (22) M src/modules/ims_auth/ims_auth_mod.c (73) A src/modules/ims_auth/milenage.c (290) A src/modules/ims_auth/milenage.h (37)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4054.patch https://github.com/kamailio/kamailio/pull/4054.diff
Merged #4054 into master.
It was already merged without review. But for reference, there is a AES (Rijndael) implementation in the core/crypto available. Then this additional dependency to the gcrypt would probably not necessary.
Code was on my computer and normally I would have pushed it directly, but I this time I wanted to see if PR compile checks on some other OSes go fine. I am aware of the crypto functions in the core, the use of gcrypt was done to create the framework for being able to extend with other crypto algorithms in the future, not only aes, several commits being done by the initial author of the module.
Thanks for the feedback, make sense.