<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4090
-- Commit Summary --
* examples: fix kamailio ims cfg file for basic volte call
-- File Changes --
M misc/examples/ims/icscf/icscf.cfg.sample (12) M misc/examples/ims/icscf/icscf.xml.sample (6) M misc/examples/ims/icscf/kamailio.cfg (32) M misc/examples/ims/pcscf/kamailio.cfg (182) M misc/examples/ims/pcscf/pcscf.cfg.sample (55) M misc/examples/ims/pcscf/pcscf.xml.sample (6) M misc/examples/ims/pcscf/route/mo.cfg (99) M misc/examples/ims/pcscf/route/mt.cfg (101) M misc/examples/ims/pcscf/route/register.cfg (198) M misc/examples/ims/pcscf/route/rtp.cfg (90) M misc/examples/ims/scscf/kamailio.cfg (115) M misc/examples/ims/scscf/scscf.cfg.sample (24) M misc/examples/ims/scscf/scscf.xml.sample (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4090.patch https://github.com/kamailio/kamailio/pull/4090.diff
Thanks, if no other comment, it will be merge soon -- it affect the additional cfg examples/docs.
@henningw commented on this pull request.
Thanks for the PR. One generic question as there are quite a lot of changes, does it make sense to maybe keep the existing example cfg and create new ones for the VoLTE setup? If the existing cfg is not working anymore, it obviously don't make sense.
Then one specific comment, you are still using the "modules_k" path in the cfg. This is obsolete since many years and you can remove that path component.
Thanks for the review.
@henningw
One generic question as there are quite a lot of changes, does it make sense to maybe keep the existing example cfg and create new ones for the VoLTE setup? If the existing cfg is not working anymore, it obviously don't make sense.
I dont mind having a separate folder for VoLTE setup. But, last I checked the existing cfg didnt work but maybe others in the community can confirm this.
Then one specific comment, you are still using the "modules_k" path in the cfg. This is obsolete since many years and you can remove that path component.
Didn't know about this. I will do the necessary changes
Thanks for the feedback. If the existing cfgs are not working I am fine in updating them of course, then they don't need to be kept.
@herlesupreeth pushed 1 commit.
8a5867f04a37e9367c2a76355025abc5b510af6a examples: fix kamailio ims cfg file for basic volte call
Merged #4090 into master.
Thank you, merged. If somebody is still interested in the old examples, they can be found in the existing older releases. If necessary they could be also added as a second directory etc..
-
Daniel-Constantin Mierla -
Henning Westerholt
-
Supreeth Herle