<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> This patch set contains a bunch of improvements to the imc module. Most of the changes are backwards-compatible, but some change the semantics of individual imc commands slightly. I have tested the changes with the Zoiper client on Android and with a custom WebRTC client. The motivation behind these changes was to make the imc module a bit more consistent, predictable, and usable. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1869
-- Commit Summary --
* Rename command "deny" to "reject" * Minor language fixes * Rename "exit" to "leave", keep backward compatiblity * Remove code duplication. * Collect chat room related strings in one place. * Use STR_FMT in formatted string arguments. * Use correct command prefix in the invite message. * Make behavior of "#join" when room does not exist configurable * Define message prefix with a macro * Make behavior of "#create" configurable when room already exists * Pass both parsed and unparsed URIs to all command handlers * Consistent handling of command parameters. * Make #create command arguments optional * Rename command #list to #members. * Cleanup in invite related messages. * Consistent formatting of room/user names. * Improved #join command handling * Notify user #leaving a room. * Make message buffer larger * A small fix in #join * Check arguments in #invite * Implement command #add * Implement command #rooms * Add In-Reply-To header to MESSAGEs generated in response * Add Supported header to all chat room MESSAGEs. * Report error if room owner sends #leave
-- File Changes --
M src/modules/imc/README (6) M src/modules/imc/doc/imc_admin.xml (62) M src/modules/imc/imc.c (92) M src/modules/imc/imc.h (8) M src/modules/imc/imc_cmd.c (1595) M src/modules/imc/imc_cmd.h (66) M src/modules/imc/imc_mng.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1869.patch https://github.com/kamailio/kamailio/pull/1869.diff
Closed #1869.
Thanks! I applied you commits manually with `git am ...` after editing the first line of each commit message to follow the contributing guidelines:
* https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com...
Respectively, I added the `imc: ` prefix there.
We use git log to generate the changelog for each release and it is useful to spot quickly which component was affected by that commit.
Another remark for the future: you do not need to generate the README locally and then create a commit for it. You can generate it locally to check if all is ok with the docbook syntax, but then you can delete the file and do git checkout path/to/the/README. This is because we generate the readme files for modules via a cron.d job on kamailio server in order to have coherent format of the output. In the past, a small change to the docbook file could end up in a completely different style of whitespacing in the README, depending on the system where the README was generated.
Last, you have git write privileges, so you can push commits directly without making pull requests. If you want someone to review the patches, then of course you can do pull requests (btw, I haven't really reviewd the code of your commits in this pull request at this moment, only edited the patch set for proper commit message format). The imc module doesn't have an active maintainer, you can step in if you plan to work more on this module, so there is no need for additional review unless you want explicitly.
-
Daniel-Constantin Mierla -
Jan Janak