This is a complete refactor of cdp log. In particular: - It removes escape chars for colors in log: they are most of the times not interpreted so they are messing up the logs - It refactors some log level, moving to ERROR from WARN some errors during peer connections - In DEBUG level, cdp is too much verbose and also syslogs complains about rate-limiting. Instead of removing some logs (which is quite unfair), let's introduce a new modparam (debug_heavy) in order to activate some logs which gives some side informations about peers status. This modparam is not active by default but this can be enabled easily re-introducing previous debug logs You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/692 -- Commit Summary -- * cdp: Review log level on peer_connect() function * cdp: Remove escape chars for colors in log * cdp: Review of logging of cdp -- File Changes -- M modules/cdp/globals.h (10) M modules/cdp/mod.c (2) M modules/cdp/peermanager.c (27) M modules/cdp/peermanager.h (2) M modules/cdp/peerstatemachine.c (2) M modules/cdp/receiver.c (34) M modules/cdp/receiver.h (2) M modules/cdp/session.c (74) M modules/cdp/session.h (2) M modules/cdp/tcp_accept.c (2) M modules/cdp/tcp_accept.h (2) M modules/cdp/transaction.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/692.patch https://github.com/kamailio/kamailio/pull/692.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/692