Patches item #3035382, was opened at 2010-07-27 18:11 Message generated for change (Comment added) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035382...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Fix transformation tobody.params

Initial Comment: The transofrmation tobody.params can't handle quoted parameters well. If the last parameter is quoted, the output of the transofrmation is truncated by 2 characters.. Attached patch fixes this.

----------------------------------------------------------------------

Comment By: Alex Hermann (axlh)

Date: 2010-07-28 08:42

Message: Well, not a good start :(

I split the patch into 2 parts.

Part 1: Fix a off-by-one bug in parsing quoted parameters. The parameter value is shortened by 1 character.

Part 2: Fix the tobody.params tranformation when the last paremeter has a quoted value. I found another solution: Just assume the parameter list ends on the end of the header line that gets pushed to the parser. Seems to work just as well, and prevents adjusting the rest of the code (tm).

----------------------------------------------------------------------

Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-27 22:25

Message: I reverted the commit on 1.5 branch - it was incomplete as the compilation got broken. Also, there should not be any commit on the trunk branch, the devel version is now on GIT repository hosted at git.sip-router.org.

The bug tracker in use is as well by sip-router.org: http://sip-router.org/tracker

Back to issue, apart of breaking the compilation, it could be a solution to store the hook for start of parameters and the length, but I didn't understand why you changed the len of quoted value.

Moreover, there are other places that needs to be updated when the to_body structure is updated with new attributes storing pointers, like cloning for TM transactions.

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035382...