THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#115 - bug in dialplan or core re.c User who did this - Juha Heinanen (jh)
---------- i have made the tests with latest 3.1 from git. here is what happens with subst_exp ^(.+:)+358(.+) and input uri sip:+35892345674@test.fi using various repl_exps:
- if repl_exp is \1\2, i get what is expected, i.e., both \1 and \2 are replaced and consumed:
Feb 22 09:40:39 sip /usr/sbin/sip-proxy[7323]: INFO: uri sip:92345674@test.fi
- if repl_exp is \1X\2, \1 is replaced but not consumed and i get:
Feb 22 09:42:48 sip /usr/sbin/sip-proxy[7484]: INFO: uri sip:\1X92345674@test.fi
- if repl_exp is \1X\2Y, i get
Feb 22 09:44:50 sip /usr/sbin/sip-proxy[7642]: INFO: uri sip:\1X92345674@test.fiY
i.e., \2 is correctly replaced and consumed, but again \1 is replaced, but not consumed.
-- juha
Feb 22 09:44:16 sip /usr/sbin/sip-proxy[7481]: INFO: pai_uri sip:\1X92345674@test.fi Feb 22 09:44:51 sip /usr/sbin/sip-proxy[7640]: NOTICE: Discarding unmatched CANCEL to sip:032345670@test.fi
----------
More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=115#comment16...
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
i found and fixed the bug in processing dialplan replacement expressions. now repl_exps that contain normal chars and back references \d (REPLACE_NMATCH) work ok.
i have not tested with REPLACE_CHAR, REPLACE_URI, REPLACE_SPEC repl_exp tokens and don't even know how they are written in repl_exp. however, their processing does not include any variables, whose values i modified in the code, so if these worked before, they should work also after my modifications.
i committed the fix to master, but not to 3.1 yet. i'll wait a few days for comments and if no one objects, i'll cherry pick the commit to 3.1.
--- juha
Hello,
On 2/26/11 4:27 AM, Juha Heinanen wrote:
i found and fixed the bug in processing dialplan replacement expressions. now repl_exps that contain normal chars and back references \d (REPLACE_NMATCH) work ok.
i have not tested with REPLACE_CHAR, REPLACE_URI, REPLACE_SPEC repl_exp tokens and don't even know how they are written in repl_exp. however, their processing does not include any variables, whose values i modified in the code, so if these worked before, they should work also after my modifications.
i committed the fix to master, but not to 3.1 yet. i'll wait a few days for comments and if no one objects, i'll cherry pick the commit to 3.1.
thank you for taking care of it.
A variable is written as usual: $name or $name(abc) The r-uri is afaik: \u The char should be any other \x than \u and \0 ... \9
Cheers, DAniel