26 Mar
2013
26 Mar
'13
10:49 p.m.
Hello,
I think the conditional on line 1316 of tcp_read.c is incorrect. The
check is currently:
if (cfg_get(tcp, tcp_cfg, accept_no_cl)==0) {
but I think it should be:
if (cfg_get(tcp, tcp_cfg, accept_no_cl)!=0) {
Does anyone disagree? If not I will fix it tomorrow.
Regards,
Peter
--
Peter Dunkley
Technical Director
Crocodile RCS Ltd
26 Mar
26 Mar
11:26 p.m.
Hello,
On 3/26/13 10:49 PM, Peter Dunkley wrote:
Hello,
I think the conditional on line 1316 of tcp_read.c is incorrect. The
check is currently:
if (cfg_get(tcp, tcp_cfg, accept_no_cl)==0) {
but I think it should be:
if (cfg_get(tcp, tcp_cfg, accept_no_cl)!=0) {
Does anyone disagree? If not I will fix it tomorrow.
didn't analyze it that
deep, but the printed error message inside the
if-block suggests the right ways is the current form.
If the content-length is not found and accept_no_cl is not set (so it is
zero), then throw error.
Cheers,
Daniel
--
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, April 16-17, 2013, Berlin
- http://conference.kamailio.com -
27 Mar
27 Mar
12:35 p.m.
Hi,
My misunderstanding. The part that confused me is that cfg_get(tcp,
tcp_cfg, accept_no_cl) always checks for == 0 or !=0, but the cfg_get()
function itself can return -1 in error cases - which doesn't seem to be
properly handled in most places. As a result I got a bit confused about
the meaning of the return codes.
Thanks,
Peter
On 26/03/13 22:26, Daniel-Constantin Mierla wrote:
Hello,
On 3/26/13 10:49 PM, Peter Dunkley wrote:
Hello,
I think the conditional on line 1316 of tcp_read.c is incorrect. The
check is currently:
if (cfg_get(tcp, tcp_cfg, accept_no_cl)==0) {
but I think it should be:
if (cfg_get(tcp, tcp_cfg, accept_no_cl)!=0) {
Does anyone disagree? If not I will fix it tomorrow.
didn't analyze it that
deep, but the printed error message inside the
if-block suggests the right ways is the current form.
If the content-length is not found and accept_no_cl is not set (so it
is zero), then throw error.
Cheers,
Daniel
4237
days inactive
4238
days old
2 comments
2 participants
participants (2)
-
Daniel-Constantin Mierla -
Peter Dunkley