Hi,
Please review the following patch for adding CQL query support to the Cassandra DB module.
The patch allows CQL queries to be passed by the script and are returned to the script through the already existing means (AVPOPS, SQLOPS).
This patch tested this through means of AVPOPS module and this is working.
Thanks,
Boudewyn Ligthart (Bou)
Please use this patch file, it patches the dbcassa_bas.cpp file.
Thanks,
Bou
From: sr-dev-bounces@lists.sip-router.org [mailto:sr-dev-bounces@lists.sip-router.org] On Behalf Of Boudewyn Ligthart Sent: 03 September 2012 15:27 To: sr-dev@lists.sip-router.org Subject: [sr-dev] Cassandra module add CQL query support
Hi,
Please review the following patch for adding CQL query support to the Cassandra DB module.
The patch allows CQL queries to be passed by the script and are returned to the script through the already existing means (AVPOPS, SQLOPS).
This patch tested this through means of AVPOPS module and this is working.
Thanks,
Boudewyn Ligthart (Bou)
Hi Boudewyn,
Thank you very much for your contribution. I have looked in the patch and it seems ok. Could you please also complete the documentation and add that the module has support for raw queries. Please specify that they have to be CQL queries. If you have trouble with the documentation xml, I can help you.
Thanks and regards, Anca
On 09/03/2012 05:59 PM, Boudewyn Ligthart wrote:
Please use this patch file, it patches the dbcassa_bas.cpp file.
Thanks,
Bou
*From:*sr-dev-bounces@lists.sip-router.org [mailto:sr-dev-bounces@lists.sip-router.org] *On Behalf Of *Boudewyn Ligthart *Sent:* 03 September 2012 15:27 *To:* sr-dev@lists.sip-router.org *Subject:* [sr-dev] Cassandra module add CQL query support
Hi,
Please review the following patch for adding CQL query support to the Cassandra DB module.
The patch allows CQL queries to be passed by the script and are returned to the script through the
already existing means (AVPOPS, SQLOPS).
This patch tested this through means of AVPOPS module and this is working.
Thanks,
Boudewyn Ligthart (Bou)
Thank you Anca,
I have ammended the documentation to allow for CQL query support. I have also added myself in the Author list, not really sure if this is the done thing. This patch can be run from the main kamailio location.
Very happy to contribute.
Kind regards,
Bou
From: sr-dev-bounces@lists.sip-router.org [mailto:sr-dev-bounces@lists.sip-router.org] On Behalf Of Anca Vamanu Sent: 03 September 2012 16:27 To: sr-dev@lists.sip-router.org Subject: Re: [sr-dev] Cassandra module add CQL query support
Hi Boudewyn,
Thank you very much for your contribution. I have looked in the patch and it seems ok. Could you please also complete the documentation and add that the module has support for raw queries. Please specify that they have to be CQL queries. If you have trouble with the documentation xml, I can help you.
Thanks and regards, Anca
On 09/03/2012 05:59 PM, Boudewyn Ligthart wrote: Please use this patch file, it patches the dbcassa_bas.cpp file.
Thanks,
Bou
From: sr-dev-bounces@lists.sip-router.orgmailto:sr-dev-bounces@lists.sip-router.org [mailto:sr-dev-bounces@lists.sip-router.org] On Behalf Of Boudewyn Ligthart Sent: 03 September 2012 15:27 To: sr-dev@lists.sip-router.orgmailto:sr-dev@lists.sip-router.org Subject: [sr-dev] Cassandra module add CQL query support
Hi,
Please review the following patch for adding CQL query support to the Cassandra DB module.
The patch allows CQL queries to be passed by the script and are returned to the script through the already existing means (AVPOPS, SQLOPS).
This patch tested this through means of AVPOPS module and this is working.
Thanks,
Boudewyn Ligthart (Bou)
Hi Bou,
I have committed the patch in cassandra module : http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=18c5f3fe....
I have tested myself and made some small changes. There was a memory leak with the cassa_cql_res variable, I made this static. Also I handled the case when no result is returned as there was a segmentation fault in this case. Please test the final patch yourself also.
Thank you for the contribution, hope we'll see more :).
Regards, Anca
On 09/03/2012 08:10 PM, Boudewyn Ligthart wrote:
Thank you Anca,
I have ammended the documentation to allow for CQL query support. I have also added myself in the Author list,
not really sure if this is the done thing. This patch can be run from the main kamailio location.
Very happy to contribute.
Kind regards,
Bou
Hi Anca,
Thanks for sorting that out. It's been a pleasure working with you.
Regards,
Bou
From: sr-dev-bounces@lists.sip-router.org [mailto:sr-dev-bounces@lists.sip-router.org] On Behalf Of Anca Vamanu Sent: 04 September 2012 14:25 To: sr-dev@lists.sip-router.org Subject: Re: [sr-dev] Cassandra module add CQL query support
Hi Bou,
I have committed the patch in cassandra module : http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=18c5f3fe....
I have tested myself and made some small changes. There was a memory leak with the cassa_cql_res variable, I made this static. Also I handled the case when no result is returned as there was a segmentation fault in this case. Please test the final patch yourself also.
Thank you for the contribution, hope we'll see more :).
Regards, Anca
On 09/03/2012 08:10 PM, Boudewyn Ligthart wrote: Thank you Anca,
I have ammended the documentation to allow for CQL query support. I have also added myself in the Author list, not really sure if this is the done thing. This patch can be run from the main kamailio location.
Very happy to contribute.
Kind regards,
Bou