<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
ITNOA
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue #4106 (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4107
-- Commit Summary --
* Change C standard version to 23
-- File Changes --
M CMakeLists.txt (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4107.patch https://github.com/kamailio/kamailio/pull/4107.diff
Hi @xkaraman
Do you can review my PR?
thanks
This PR introduces a quite step change, which should be properly discussed before deciding. I will add some comments to the linked issue.
@soroshsabz pushed 1 commit.
9313b5d39b1afb9244569fb2f9145186f78e5e26 Update CMakeLists.txt
Hey @soroshsabz.
This change is indeed quite steep as @henningw said. If you want, though you can try compiling kamailio with C17 by passing the option to `cmake` configuration phase,
`cmake -S . -B build-folder -DCMAKE_C_STANDARD=C17 -DCMAKE_C_STANDARD_REQUIRED=True`. This will try to compile with C17 enabled.
If it compiles successfully and you want to propose it to the community, please do so in the kamailio dev list. It will probably need some fixes to confront C17, but you are welcome to contribute if you want.
@xkaraman thanks for your reply, I test it and compile correctly, where is kamailio dev list?
You can find the lists here: https://www.kamailio.org/w/mailing-lists/
github-actions[bot] left a comment (kamailio/kamailio#4107)
This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.
Closed #4107.