#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #2645
#### Description For #2645, a patch was pushed in 47b45b60a037808a675f7d52dd5b2ee80bfe0868, but this code does not correctly check the return value of `str2ip6buf` and `str2ipbuf`.
As described in the comments on both methods, they return zero *for success*.
This MR should be backported to 5.4 as well. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2695
-- Commit Summary --
* Fix ip parsing in ipops
-- File Changes --
M src/modules/ipops/ipops_mod.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2695.patch https://github.com/kamailio/kamailio/pull/2695.diff
You have to format the commit message as per contributing guidelines:
* https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com...
Being small changes, I can do the fix manually this time.
Slightly different patch was committed and backported. Thanks!
Closed #2695.