[kamailio/kamailio] Restrict app_python to Python2 enabling builds on systems where Python3 is the default (#1645)
The following change enables app_python (which only works with Python2 anyway) to build on systems where Python3 is the default (Fedora 29). ``` diff --git a/src/modules/app_python/Makefile b/src/modules/app_python/Makefile index d1854c12e..c9ad254c3 100644 --- a/src/modules/app_python/Makefile +++ b/src/modules/app_python/Makefile @@ -9,7 +9,7 @@ NAME=app_python.so # the following to point to the correct instance. Module has been tested # to work with 2.6 and 2.5. Python 2.4 has been only confirmed to compile, # but no testing has been done with that. -PYTHON?=python +PYTHON?=python2
PYTHON_VERSION=${shell ${PYTHON} -c "import distutils.sysconfig;print distutils.sysconfig.get_config_var('VERSION')"} PYTHON_LIBDIR=${shell ${PYTHON} -c "import distutils.sysconfig;print distutils.sysconfig.get_config_var('LIBDIR')"} ```
Closed #1645.
Thank you, commited to git master. Will also backport to 5.0 and 5.1 branch.
On macos there is no `python2`, but `python` and `python2.7`. So I guess this needs to be updated in the way of checking if `python2` exits (`which python2`) and if yes, use it, otherwise set it to `python`. I expect that only distro having `python3` are shipping `python2`, old distros with python 2.x only, likely don't have `python2`.
Hi Daniel, I looked at opensuse, debian 8 and debian 9 - all have this python2 link, interesting that MacOS here is different. But will add something like this, would be great if you could test as I have no access to MacOS.
Reopened #1645.
Daniel - could you give a52e7cb1 a quick test?
Master branch compiles ok.
Closed #1645.
Ok, thanks, will backport it as well.
@henningw @miconda lightning quick. Thank you!
-
Anthony Messina -
Daniel-Constantin Mierla
-
Henning Westerholt